115354 - Trunk, M097 Crash on exit [@ createNode]

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P1)

Description

[scottputterman]

I've crashed twice while exiting on the 12/14 build on NT 4.0

Here's the talkback id's: 490602 and 490020

The top of the stack looks like:

createNode [d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgRDFUtils.cpp,
line 51]
nsMsgFolderDataSource::GetNumMessagesNode
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgFolderDataSource.cpp, line 1793]
nsMsgFolderDataSource::OnTotalMessagePropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgFolderDataSource.cpp, line 1779]
nsMsgFolderDataSource::OnItemIntPropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgFolderDataSource.cpp, line 873]
nsMsgMailSession::OnItemIntPropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgMailSession.cpp, line 198]
nsMsgFolder::NotifyIntPropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgFolder.cpp, line 2350]
nsImapMailFolder::UpdateSummaryTotals
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapMailFolder.cpp, line 1440]
nsImapMailFolder::GetDatabase
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapMailFolder.cpp, line 601]
nsImapMailFolder::GetDBFolderInfoAndDB
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapMailFolder.cpp, line 1731]
nsMsgDBFolder::ReadDBFolderInfo
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp, line 421]

Comment 1

[laurel]

I've hit it several times 12/13-14 builds, win98.

Comment 2

[scottputterman]

It's very possible this is a dup of 106330 but since that was closed for a
while, I guess we can let this one stay open.  That crash happened when updating
the folder name on exit.  The crash I'm hitting seems to be the folder counts.
My guess is they are related.

Putting in 0.9.7 for the moment.  There are a bunch of talkback reports over the
last couple of days.  

Adding Bhuvan and Navin to see if they can help with this as well.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This looks like the #1 crash on the trunk right now.

Comment 4

[Navin Gupta]

I believe rdfService is being unregistered from underneath us. null check 
for rdfService should fix the problem, but why are we creating node on exit
is worth investigating. 

Comment 5

[David :Bienvenu]

I suspect you're right about checking for null rdf service fixing this crash,
but as far as creating nodes on exit is concerned, we've been doing that off and
on for a long time - a deeper stack trace would show better why. Here's the rest
of the stack trace, which shows that, on shutdown, we're calling GetSubfolders
(because we have to write out all the folders), which causes a GetFlags call,
etc. I believe someone changed this not too long ago, actually.

nsMsgDBFolder::ReadDBFolderInfo
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp, line 421]
nsMsgDBFolder::GetFlags
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp, line 931]
nsImapMailFolder::AddSubfolderWithPath
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapMailFolder.cpp, line 339]
nsImapMailFolder::CreateSubFolders
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapMailFolder.cpp, line 496]
nsImapMailFolder::GetSubFolders
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapMailFolder.cpp, line 542]
nsMsgDBFolder::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp, line 1049]
nsMsgDBFolder::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp, line 1068]
nsMsgIncomingServer::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgIncomingServer.cpp, line 189]
nsMsgAccountManager::writeFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp, line 975]
_hashEnumerate [d:\builds\seamonkey\mozilla\xpcom\ds\nsHashtable.cpp, line 199]
PL_HashTableEnumerateEntries [../../../lib/ds/plhash.c, line 430]
nsHashtable::Enumerate [d:\builds\seamonkey\mozilla\xpcom\ds\nsHashtable.cpp,
line 362]
nsMsgAccountManager::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp, line 1479]
nsMsgAccountManager::Shutdown
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp, line 206]
nsMsgAccountManager::Observe
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp, line 270]
nsObserverService::NotifyObservers
[d:\builds\seamonkey\mozilla\xpcom\ds\nsObserverService.cpp, line 214]
NS_ShutdownXPCOM [d:\builds\seamonkey\mozilla\xpcom\build\nsXPComInit.cpp, line 518]

Comment 6

[David :Bienvenu]

I think it's this code here that causes GetFlags to get called:

                        PRBool isServer;
345                     rv = GetIsServer(&isServer);
346                  
347                     PRInt32 pFlags;
348                     GetFlags ((PRUint32 *) &pFlags);
349                     PRBool isParentInbox = pFlags & MSG_FOLDER_FLAG_INBOX;
350                   
351                     //Only set these if these are top level children or
parent is inbox

Comment 7

[Navin Gupta]

taking

Comment 8

[Navin Gupta]

I am not able to crash during shutdown. Is there something which needs to be 
done to crash. we may not need to do GetFlags over there, mFlags should be
ok, if that's causing the crash. 

Comment 9

[Navin Gupta]

from talkback, crash on linux. The problem is that m_initialized flag in 
local/imap folder seems not set for some reason, which leads to these crashes. 
I will bullet proof it for now. 

createNode() 
nsMsgFolderDataSource::NotifyFolderTreeNameChanged() 
nsMsgFolderDataSource::OnItemUnicharPropertyChanged() 
nsMsgMailSession::OnItemUnicharPropertyChanged() 
nsMsgFolder::NotifyUnicharPropertyChanged() 
nsMsgFolder::SetName() 
nsMsgLocalMailFolder::CreateSubFolders() 
nsMsgLocalMailFolder::GetSubFolders() 
nsMsgDBFolder::WriteToFolderCache() 
nsMsgDBFolder::WriteToFolderCache() 
nsMsgDBFolder::WriteToFolderCache() 
nsMsgIncomingServer::WriteToFolderCache() 
nsMsgAccountManager::writeFolderCache() 
_hashEnumerate__FP11PLHashEntryiPv() 
PL_HashTableEnumerateEntries() 
nsHashtable::Enumerate() 
nsMsgAccountManager::WriteToFolderCache() 
nsMsgAccountManager::Shutdown() 
nsMsgAccountManager::Observe() 
nsObserverService::NotifyObservers() 
NS_ShutdownXPCOM() 
main() 
libc.so.6 + 0x1d7ee (0x404c67ee) 

Comment 10

[Navin Gupta]

Attachment: bullet proof fix

assert if rdfService is null and return.

Comment 11

[David :Bienvenu]

Comment on attachment 61994 [details] [diff] [review]
bullet proof fix

sr=bienvenu

Comment 12

[Navin Gupta]

fixed. we will now assert in the debug build. 

Comment 13

[scottputterman]

*** Bug 115165 has been marked as a duplicate of this bug. ***

Comment 14

[scottputterman]

I'm going to verify this.  From looking at the talkback reports you can see that
there were many crashes with each build prior to the fix.  The last build with a
crash is 12/17 which is the morning before the fix was checked in.

Comment 15

[scottputterman]

*** Bug 112843 has been marked as a duplicate of this bug. ***

Comment 16

[Jay Patel [:jay]]

Did this fix make it into Mozilla 0.9.7?  The latest Talkback data shows this as
a topcrasher for M097 (Windows build 2001122109):

Rank    StackSignature    Count  

8   createNode   229
		 118034 	 NEW 	  	 [e-mail] 	 --- 	 2002-01-09
		 106330 	 VERI 	 WORK 	 [e-mail] 	 mozilla0.9.6 	 2001-12-20
		 115354 	 VERI 	 FIXE 	 [e-mail] 	 mozilla0.9.7 	 2002-01-04 
 
====================================================================================================
     Count   Offset    Real Signature
[ 16   createNode e239e7e0 - createNode ]
 
     Crash date range: 2002-01-10 to 2002-01-15
     Min/Max Seconds since last crash: 44 - 9777
     Min/Max Runtime: 98 - 87687
     Keyword List :  
     Count   Platform List 
     16   Windows NT 4.0 build 1381
 
     Count   Build Id List 
     16   2001122109
 
     No of Unique Users         2
 
 Stack trace(Frame) 

	 createNode
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgRDFUtils.cpp  line 51] 
	 nsMsgFolderDataSource::NotifyFolderTreeNameChanged
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgFolderDataSource.cpp  line
1661] 
	 nsMsgFolderDataSource::OnItemUnicharPropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgFolderDataSource.cpp  line 898] 
	 nsMsgMailSession::OnItemUnicharPropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgMailSession.cpp  line 168] 
	 nsMsgFolder::NotifyUnicharPropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgFolder.cpp  line 2323] 
	 nsMsgFolder::SetName
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgFolder.cpp  line 900] 
	 nsMsgLocalMailFolder::CreateSubFolders
[d:\builds\seamonkey\mozilla\mailnews\local\src\nsLocalMailFolder.cpp  line 247] 
	 nsMsgLocalMailFolder::GetSubFolders
[d:\builds\seamonkey\mozilla\mailnews\local\src\nsLocalMailFolder.cpp  line 478] 
	 nsMsgDBFolder::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp  line 1049] 
	 nsMsgDBFolder::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp  line 1068] 
	 nsMsgIncomingServer::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgIncomingServer.cpp  line 189] 
	 nsMsgAccountManager::writeFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp  line 975] 
	 _hashEnumerate
[d:\builds\seamonkey\mozilla\xpcom\ds\nsHashtable.cpp  line 199] 
	 PL_HashTableEnumerateEntries
[../../../lib/ds/plhash.c  line 430] 
	 nsHashtable::Enumerate
[d:\builds\seamonkey\mozilla\xpcom\ds\nsHashtable.cpp  line 362] 
	 nsMsgAccountManager::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp  line 1479] 
	 nsMsgAccountManager::Shutdown
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp  line 206] 
	 nsMsgAccountManager::Observe
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp  line 270] 
	 nsObserverService::NotifyObservers
[d:\builds\seamonkey\mozilla\xpcom\ds\nsObserverService.cpp  line 214] 
	 NS_ShutdownXPCOM
[d:\builds\seamonkey\mozilla\xpcom\build\nsXPComInit.cpp  line 518] 
	 main
[d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp  line 1605] 
	 WinMain
[d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp  line 1615] 
	 WinMainCRTStartup()  
	 KERNEL32.dll + 0x1bbb5 (0x77f1bbb5)   
 
     (1673634)	URL: closing mozilla -mail 0.9.7 de-at in WinNT4de
     (1669452)	URL: closing mozilla -mail 0.9.7 de-at in WinNT4de
     (1669120)	Comments: Exiting the "Mozilla Quick Start" in the Systray
     (1632997)	URL: closing mozilla -mail 0.9.7 de-at in WinNT4de
     (1630669)	URL: closing mozilla -mail 0.9.7 de-at in WinNT4de
     (1622511)	URL: closing mozilla -mail 0.9.7 even without german language pack
 
====================================================================================================
     Count   Offset    Real Signature
[ 10   createNode fba52f01 - createNode ]
[ 10   createNode 115c5441 - createNode ]
 
     Crash date range: 2002-01-08 to 2002-01-10
     Min/Max Seconds since last crash: 23 - 82334
     Min/Max Runtime: 10393 - 323151
     Keyword List :  
     Count   Platform List 
     10   Windows NT 5.1 build 2600
     10   Windows NT 4.0 build 1381
 
     Count   Build Id List 
     20   2001122109
 
     No of Unique Users         3
 
 Stack trace(Frame) 

	 createNode
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgRDFUtils.cpp  line 51] 
	 nsMsgFolderDataSource::NotifyFolderTreeNameChanged
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgFolderDataSource.cpp  line
1661] 
	 nsMsgFolderDataSource::OnItemUnicharPropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgFolderDataSource.cpp  line 898] 
	 nsMsgMailSession::OnItemUnicharPropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgMailSession.cpp  line 168] 
	 nsMsgFolder::NotifyUnicharPropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgFolder.cpp  line 2323] 
	 nsMsgFolder::SetName
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgFolder.cpp  line 900] 
	 nsMsgLocalMailFolder::CreateSubFolders
[d:\builds\seamonkey\mozilla\mailnews\local\src\nsLocalMailFolder.cpp  line 247] 
	 nsMsgLocalMailFolder::GetSubFolders
[d:\builds\seamonkey\mozilla\mailnews\local\src\nsLocalMailFolder.cpp  line 478] 
	 nsMsgDBFolder::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp  line 1049] 
	 nsMsgDBFolder::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp  line 1068] 
	 nsMsgDBFolder::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp  line 1068] 
	 nsMsgDBFolder::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp  line 1068] 
	 nsMsgIncomingServer::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgIncomingServer.cpp  line 189] 
	 nsMsgAccountManager::writeFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp  line 975] 
	 _hashEnumerate
[d:\builds\seamonkey\mozilla\xpcom\ds\nsHashtable.cpp  line 199] 
	 PL_HashTableEnumerateEntries
[../../../lib/ds/plhash.c  line 430] 
	 nsHashtable::Enumerate
[d:\builds\seamonkey\mozilla\xpcom\ds\nsHashtable.cpp  line 362] 
	 nsMsgAccountManager::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp  line 1479] 
	 nsMsgAccountManager::Shutdown
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp  line 206] 
	 nsMsgAccountManager::Observe
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp  line 270] 
	 nsObserverService::NotifyObservers
[d:\builds\seamonkey\mozilla\xpcom\ds\nsObserverService.cpp  line 214] 
	 NS_ShutdownXPCOM
[d:\builds\seamonkey\mozilla\xpcom\build\nsXPComInit.cpp  line 518] 
	 main
[d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp  line 1605] 
	 WinMain
[d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp  line 1615] 
	 WinMainCRTStartup()  
	 kernel32.dll + 0x1eb69 (0x77e5eb69)   
 
 
====================================================================================================
     Count   Offset    Real Signature
[ 10   createNode 5d52b0e4 - createNode ]
 
     Crash date range: 2002-01-06 to 2002-01-13
     Min/Max Seconds since last crash: 67 - 185552
     Min/Max Runtime: 25303 - 557338
     Keyword List :  
     Count   Platform List 
     10   Windows NT 5.0 build 2195
 
     Count   Build Id List 
     10   2001122109
 
     No of Unique Users         4
 
 Stack trace(Frame) 

	 createNode
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgRDFUtils.cpp  line 51] 
	 nsMsgFolderDataSource::NotifyFolderTreeNameChanged
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgFolderDataSource.cpp  line
1661] 
	 nsMsgFolderDataSource::OnItemUnicharPropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgFolderDataSource.cpp  line 898] 
	 nsMsgMailSession::OnItemUnicharPropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgMailSession.cpp  line 168] 
	 nsMsgFolder::NotifyUnicharPropertyChanged
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgFolder.cpp  line 2323] 
	 nsMsgFolder::SetName
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgFolder.cpp  line 900] 
	 nsImapMailFolder::CreateSubFolders
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapMailFolder.cpp  line 504] 
	 nsImapMailFolder::GetSubFolders
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapMailFolder.cpp  line 542] 
	 nsMsgDBFolder::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp  line 1049] 
	 nsMsgDBFolder::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp  line 1068] 
	 nsMsgDBFolder::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp  line 1068] 
	 nsMsgIncomingServer::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgIncomingServer.cpp  line 189] 
	 nsMsgAccountManager::writeFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp  line 975] 
	 _hashEnumerate
[d:\builds\seamonkey\mozilla\xpcom\ds\nsHashtable.cpp  line 199] 
	 PL_HashTableEnumerateEntries
[../../../lib/ds/plhash.c  line 430] 
	 nsHashtable::Enumerate
[d:\builds\seamonkey\mozilla\xpcom\ds\nsHashtable.cpp  line 362] 
	 nsMsgAccountManager::WriteToFolderCache
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp  line 1479] 
	 nsMsgAccountManager::Shutdown
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp  line 206] 
	 nsMsgAccountManager::Observe
[d:\builds\seamonkey\mozilla\mailnews\base\src\nsMsgAccountManager.cpp  line 270] 
	 nsObserverService::NotifyObservers
[d:\builds\seamonkey\mozilla\xpcom\ds\nsObserverService.cpp  line 214] 
	 NS_ShutdownXPCOM
[d:\builds\seamonkey\mozilla\xpcom\build\nsXPComInit.cpp  line 518] 
	 main
[d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp  line 1605] 
	 WinMain
[d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp  line 1615] 
	 WinMainCRTStartup()  
	 KERNEL32.DLL + 0x17d08 (0x77e97d08)   
 
     (1460049)	URL: http://www.themes.org/35/#
     (1460049)	Comments: I was just exiting Mozilla.
     (1454156)	URL: http://www.themes.org/35/#
     (1454156)	Comments: Closing Mozilla while my rules.dat file was open in Emacs.
     (1454069)	URL: http://www.themes.org/35/#
     (1454069)	Comments: Closing Mozilla.


I'm guessing the fix went into the MozillaTrunk, but did it ever make it onto
the branch?  I'm just curious, so leaving this fixed.  If it was fixed on the
Trunk, we should be ok...

Comment 17

[scottputterman]

I had looked into this same question a couple of weeks ago and it looked like
this was not in the 0.9.7 build.

Comment 18

[Navin Gupta]

This was just checked into trunk. From www.mozilla.org/roadmap we were
in beginning of 0.9.8 (start- 14th dec).

Comment 19

[scottputterman]

*** Bug 118034 has been marked as a duplicate of this bug. ***