1153800 - Store the thumbnails associated with context as a data uri instead of a url

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Currently we're storing the thumbnails associated with context as a simple url.

The architecture calls for this to be stored as a data uri - this seems reasonable as it'd prevent issues with the website changing/removing images once someone had added them to a room.

https://wiki.mozilla.org/Loop/Architecture/Context#Format_of_context.value

RT has also said that we probably want to switch to favicons only, so doing that here as well might make it simpler.

Comment 1

[Romain Testard [:RT]]

Please let's move to Favicons only.
I copy Sevaan so he's aware - we discussed and it's his preference too.

Comment 3

[Mark Banner (:standard8)]

I've just taken a look at this. Since we're switching to favicons only, we could go simpler on the document title, and just get the title of the current tab.

Mike/Jared, do you think we should:

a) update PageMetaData to also handle favicons, or
b) just get the favicon from the favicon service and use the current document title

?

Comment 4

[Sevaan Franks [:sevaan]]

Attachment: Panel w/ Favicon Only

Note, it says "Let's talk about", not "Let's talk about this page".

Comment 5

[Sevaan Franks [:sevaan]]

Attachment: Conversation Window w/ Favicon Only

Height of box with contextual information grows if page title wraps.

Comment 6

[Sevaan Franks [:sevaan]]

Attachment: LinkClicker w/ Favicon Only

Note: Contextual information is left-aligned, not centered.

Comment 7

[Mark Banner (:standard8)]

Fixed by bug 1162903.