Closed Bug 1153806 Opened 10 years ago Closed 10 years ago

Enable encryption of room names once the server update is deployed

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Points:
1

Tracking

(firefox40 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [context][waiting on loop-client 0.16.0 to be deployed])

Attachments

(1 file, 1 obsolete file)

Enable encryption of Loop room context data.
9.93 KB, patch
mikedeboer
: review+
Details | Diff | Splinter Review
I'm currently expecting that the server will be updated before we're ready to fully turn on context. However, we should be able to turn on encryption for nightly users so that we can start getting testing and feedback on that.
Flags: firefox-backlog+
Rank: 5
Whiteboard: [waiting on server 0.17.4 to be deployed]
Whiteboard: [waiting on server 0.17.4 to be deployed] → [context][waiting on server 0.17.4 to be deployed]
Assignee: nobody → standard8
Whiteboard: [context][waiting on server 0.17.4 to be deployed] → [context][waiting on loop-client 0.16.0 to be deployed]
This enables encryption for all the places we can - everywhere in guest mode, and opportunistic in FxA. Currently the patch depends on bug 1152761, so not requesting review yet as rebase may be necessary.
Depends on: 1159520
This applies on top of bug 1152761. The aim here is to only turn on encryption of room names, and not allow context just yet. For guests, this will mean encryption for any new room or renamed room. For FxA we'll only encrypt if the user signs out and then back in again. Once we fix the remaining bugs, we can flip the pref to turn context on.
Attachment #8598653 - Attachment is obsolete: true
Attachment #8599880 - Flags: review?(mdeboer)
Comment on attachment 8599880 [details] [diff] [review] Enable encryption of Loop room context data. Review of attachment 8599880 [details] [diff] [review]: ----------------------------------------------------------------- Nice, cleanup FTW!
Attachment #8599880 - Flags: review?(mdeboer) → review+
Ok, I've re-verified this without the test_looprooms_encryption_in_fxa.js changes (the dependency on bug 1152761), and it all looks fine, so I'm going to reland this patch. I can then look into the other bug next week.
https://hg.mozilla.org/mozilla-central/rev/20d215b7378b
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: