1153892 - adjust xperf mainthreadIO to allow up to 100ms duration on file access

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

right now we limit our file access to 1ms and allow for exceptions (all but one of the ~15 exceptions are <10ms).  As discussed in a performance testing meeting the other week we should ignore all accesses <100ms and only be reporting errors on new files accessed or files >100ms.  This would greatly reduce the noise in the test and point out serious offenders.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: ignore file access of <100ms for talos xperf mainthread io (1.0)

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8591716 [details] [diff] [review]
ignore file access of <100ms for talos xperf mainthread io (1.0)

Review of attachment 8591716 [details] [diff] [review]:
-----------------------------------------------------------------

::: talos/whitelist.py
@@ +96,5 @@
>  
>      def checkDuration(self, test, file_name_index, file_duration_index):
>          errors = {}
>          for idx, (row_key, row_value) in utils.indexed_items(test.iteritems()):
> +            if row_value[file_duration_index] > 100.0:

Can you please define the 100.0 as a constant instead of using it as a literal?

@@ +106,5 @@
>                          continue
>  
>                  if filename not in errors:
>                      errors[filename] = []
> +                errors[filename].append("Duration %s > 100.0" % row_value[file_duration_index])

Modify the format string to reference the constant as well.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/build/talos/rev/3ff845dafa72