Closed Bug 1153894 Opened 10 years ago Closed 10 years ago

Submitting NPAPI plugin crashes from the hidden plugin notification bar is broken

Categories

(Core Graveyard :: Plug-ins, defect)

x86
All
defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(2 files)

This is dumb fallout from bug 1110887. The showNPAPIPluginCrashedNotification method in browser-plugins.js is using the GMP crash submit mechanism at [1], using arguments that just do not exist. Patch with regression test coming up. [1]: http://hg.mozilla.org/mozilla-central/file/2c9708e6b54d/browser/base/content/browser-plugins.js#l507
showNPAPIPluginCrashedNotification was erroneously calling submitGMPCrashReport, and attempted to call it with arguments that it definitely didn't have (pluginDumpID, browserDumpID). Now we call submitCrashReport with a runID, as expected.
Comment on attachment 8591726 [details] [diff] [review] Make NPAPI plugin crash notification bar crash submission button call the right submission method. r=? I have a regression test coming up too.
Attachment #8591726 - Flags: review?(felipc)
Attachment #8591726 - Flags: review?(felipc) → review+
Attachment #8591726 - Attachment is obsolete: true
Comment on attachment 8591726 [details] [diff] [review] Make NPAPI plugin crash notification bar crash submission button call the right submission method. r=? Silly bzexport.
Attachment #8591726 - Attachment is obsolete: false
Attachment #8591741 - Flags: review?(felipc)
Attachment #8591741 - Flags: review?(felipc) → review+
Assignee: nobody → mconley
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla40
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: