1153894 - Submitting NPAPI plugin crashes from the hidden plugin notification bar is broken

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

This is dumb fallout from bug 1110887.

The showNPAPIPluginCrashedNotification method in browser-plugins.js is using the GMP crash submit mechanism at [1], using arguments that just do not exist.

Patch with regression test coming up.

[1]: http://hg.mozilla.org/mozilla-central/file/2c9708e6b54d/browser/base/content/browser-plugins.js#l507

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Make NPAPI plugin crash notification bar crash submission button call the right submission method. r=?

showNPAPIPluginCrashedNotification was erroneously calling submitGMPCrashReport, and attempted
to call it with arguments that it definitely didn't have (pluginDumpID, browserDumpID). Now
we call submitCrashReport with a runID, as expected.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8591726 [details] [diff] [review]
Make NPAPI plugin crash notification bar crash submission button call the right submission method. r=?

I have a regression test coming up too.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Regression test. r=?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8591726 [details] [diff] [review]
Make NPAPI plugin crash notification bar crash submission button call the right submission method. r=?

Silly bzexport.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Thanks for the fast reviews!

remote:   https://hg.mozilla.org/integration/fx-team/rev/e30e217e0e47
remote:   https://hg.mozilla.org/integration/fx-team/rev/852425935a1d

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e30e217e0e47
https://hg.mozilla.org/mozilla-central/rev/852425935a1d