Closed
Bug 1153894
Opened 10 years ago
Closed 10 years ago
Submitting NPAPI plugin crashes from the hidden plugin notification bar is broken
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(2 files)
1.37 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
6.23 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
This is dumb fallout from bug 1110887.
The showNPAPIPluginCrashedNotification method in browser-plugins.js is using the GMP crash submit mechanism at [1], using arguments that just do not exist.
Patch with regression test coming up.
[1]: http://hg.mozilla.org/mozilla-central/file/2c9708e6b54d/browser/base/content/browser-plugins.js#l507
Assignee | ||
Comment 1•10 years ago
|
||
showNPAPIPluginCrashedNotification was erroneously calling submitGMPCrashReport, and attempted
to call it with arguments that it definitely didn't have (pluginDumpID, browserDumpID). Now
we call submitCrashReport with a runID, as expected.
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8591726 [details] [diff] [review]
Make NPAPI plugin crash notification bar crash submission button call the right submission method. r=?
I have a regression test coming up too.
Attachment #8591726 -
Flags: review?(felipc)
Updated•10 years ago
|
Attachment #8591726 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8591726 -
Attachment is obsolete: true
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8591726 [details] [diff] [review]
Make NPAPI plugin crash notification bar crash submission button call the right submission method. r=?
Silly bzexport.
Attachment #8591726 -
Attachment is obsolete: false
Assignee | ||
Updated•10 years ago
|
Attachment #8591741 -
Flags: review?(felipc)
Updated•10 years ago
|
Attachment #8591741 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Thanks for the fast reviews!
remote: https://hg.mozilla.org/integration/fx-team/rev/e30e217e0e47
remote: https://hg.mozilla.org/integration/fx-team/rev/852425935a1d
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e30e217e0e47
https://hg.mozilla.org/mozilla-central/rev/852425935a1d
Assignee: nobody → mconley
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla40
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•