1153948 - Regression from bug 1151875 - causing issues editing in textarea

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Mark Capella [:capella]]

Using testcase [1], I find issues backspacing after tapping into various text / words in a textarea. Backing out bug 1151875 seems to fix this. STR as I found it:

0) Use SwiftKey keyboard for auto-suggest composition support.
1) Open the link [1].
2) Tap into a word in the top textarea to position the blinking caret.
   (SelectionHandler code not involved, actionbar not required)
3) Tap backspace.
4) Tap into another word
5) Tap backspace.

repeating steps 4-5, you should see the caret jump position after tapping backspace.

[1] https://www.dropbox.com/s/j5jcon30y8vda3u/test_bug988143.html?dl=0

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Fix bug in sending text change notifications (v1)

Turns out the fix to bug 1151875 revealed a different bug from before.

nsWindow::PostFlushIMEChanges assumes that when there are changes pending, we must have ready posted the flush message. Therefore, the first time we add a change, we must call nsWindow::PostFlushIMEChanges *first*, when there's no pending change.

Comment 2

[Eugen Sawin [:esawin]]

Comment on attachment 8592961 [details] [diff] [review]
Fix bug in sending text change notifications (v1)

Review of attachment 8592961 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9443f805a17a

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9443f805a17a