1154013 - [10.10] Entire reading list sidebar flashes black when opening

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P4)

Description

[aleth [:aleth]]

STR
Open a page in reader view, then open the reading list using the button.
The entire background of the reading list sidebar is black, briefly but quite noticeably, as the sidebar is opened.

I suspect this may have something to do with the background vibrancy of the sidebar on OSX taking too many ms to apply.

Comment 1

[aleth [:aleth]]

I should add that the timespan for which the background is black seems to vary a bit (when opening and closing the sidebar a few times in succession), so maybe some async process is involved as well.

Comment 2

[aleth [:aleth]]

Not sure if this isn't a more general theme issue.

Comment 3

[Markus Stange [:mstange]]

I only see this when I resize the sidebar, but not during opening. There is definitely an async process involved here - we're not waiting on main thread drawRect (which updates vibrant regions) before compositing the new frame on the compositor thread. However, since in my tests the effect really wasn't visible unless I resized the sidebar, I didn't attempt to fix it.

Are you running with acceleration + OMTC? What does your "GPU Accelerated Windows" row on about:support say?

Comment 4

[aleth [:aleth]]

(In reply to Markus Stange [:mstange] from comment #3)
> I only see this when I resize the sidebar, but not during opening. There is
> definitely an async process involved here - we're not waiting on main thread
> drawRect (which updates vibrant regions) before compositing the new frame on
> the compositor thread. However, since in my tests the effect really wasn't
> visible unless I resized the sidebar, I didn't attempt to fix it.

I don't see it when opening the reading list sidebar from the View menu.

I *do* see it when opening the reading list sidebar via the button in reader mode (as mentioned in the description).

Maybe something about that is more akin to a resize? (e.g. is there a CSS transition?)

> Are you running with acceleration + OMTC? What does your "GPU Accelerated
> Windows" row on about:support say?

2/2 OpenGL (OMTC)
Standard settings for OSX 10.10.3, afaik.

Comment 5

[Markus Stange [:mstange]]

All right. Looks like we need to do something here.

Comment 6

[Steven Michaud [:smichaud] (Retired)]

This is a very minor issue on my Retina MacBookPro10,1.  I only see it if I move the divider (between the reading list sidebar and the rest of the page) very quickly, and then only for a small fraction of a second.

Interestingly, I don't see the issue at all on my (non-Retina) MacBookPro8,2, or even on my Retina machine if HiDPI support is off.

I also don't see the issue on OS X 10.9.5 and below.

Comment 7

[Markus Stange [:mstange]]

Yeah, I'm putting this on my "nice to fix" list of bugs, there are much more important things for me to work on at the moment.

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1154013 - When the vibrant region of a window changes, composite synchronously so that the window contents and the vibrancy update atomically. r=mattwoodrow

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21a4e55d0610
When the vibrant region of a window changes, composite synchronously so that the window contents and the vibrancy update atomically. r=mattwoodrow

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/21a4e55d0610