Closed Bug 1154063 Opened 11 years ago Closed 11 years ago

Error in parsing value for 'border'. Declaration dropped." {file: "chrome://global/skin/aboutReader.css" line: 332 column: 14 source: " border: 1px 1px 0 1px solid #b5b5b5;"

Categories

(Toolkit :: Reader Mode, defect)

Product:
Toolkit
Component:
Reader Mode
Version:
38 Branch
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Iteration:
40.2 - 27 Apr
Tracking Flags:
Tracking Status
firefox38 --- unaffected
firefox38.0.5 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: jaws, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

fix CSS issue in aboutReader.css,
1014 bytes, patch
bwinton
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review
No description provided.
status-firefox38: --- → affected
status-firefox39: --- → affected
status-firefox40: --- → affected
Target Milestone: --- → mozilla38
Target Milestone: mozilla38 → ---
Version: unspecified → 38 Branch
So, the commit listed in the annotation just changed the case of the color constant. The commit that introduced the multiple pixel specification was http://hg.mozilla.org/mozilla-central/annotate/d852fc6b7059/toolkit/themes/windows/global/aboutReader.css#l290 a.k.a bug 1142298.
Blocks: 1142298
No longer blocks: 1145809
Flags: needinfo?(gijskruitbosch+bugs)
Untested, but this should work, I think? Blake, can you check?
Attachment #8592412 - Flags: review?(bwinton)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Comment on attachment 8592412 [details] [diff] [review] fix CSS issue in aboutReader.css, Looks good to me! Tested on Mac OS X, but I see no reason it should be different on other platforms.
Attachment #8592412 - Flags: review?(bwinton) → review+
remote: https://hg.mozilla.org/integration/fx-team/rev/4d05ab7f2bd0
Iteration: --- → 40.2 - 27 Apr
Points: --- → 1
Flags: qe-verify-
Flags: in-testsuite-
Flags: firefox-backlog+
Whiteboard: [fixed-in-fx-team]
Blocks: 1132074
https://hg.mozilla.org/mozilla-central/rev/4d05ab7f2bd0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla40
Do we need to uplift this?
Flags: needinfo?(gijskruitbosch+bugs)
Comment on attachment 8592412 [details] [diff] [review] fix CSS issue in aboutReader.css, (In reply to :Margaret Leibovic from comment #7) > Do we need to uplift this? Yes. Approval Request Comment [Feature/regressing bug #]: reader mode [User impact if declined]: css errors, imperfect border [Describe test coverage new/current, TreeHerder]: nope [Risks and why]: very low, css-only [String/UUID change made/needed]: no
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8592412 - Flags: approval-mozilla-beta?
Attachment #8592412 - Flags: approval-mozilla-aurora?
Comment on attachment 8592412 [details] [diff] [review] fix CSS issue in aboutReader.css, Should be in 38.0.5beta1
Attachment #8592412 - Flags: approval-mozilla-beta?
Attachment #8592412 - Flags: approval-mozilla-beta+
Attachment #8592412 - Flags: approval-mozilla-aurora?
Attachment #8592412 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: