Closed
Bug 1154111
Opened 10 years ago
Closed 10 years ago
structured log should colorize "SKIP"
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(1 file)
|
2.19 KB,
patch
|
jgraham
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8592075 -
Flags: review?(ahalberstadt)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8592075 [details] [diff] [review]
colorize_skip.patch
Review of attachment 8592075 [details] [diff] [review]:
-----------------------------------------------------------------
This looks ok to me, but I don't understand the implications doing this might have. Passing review to James who understands this module much better than me.
Attachment #8592075 -
Flags: review?(ahalberstadt) → review?(james)
|
||
Updated•10 years ago
|
Attachment #8592075 -
Flags: review?(james) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
Assignee: nobody → hiikezoe
Keywords: checkin-needed
|
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•