Closed Bug 1154122 Opened 4 years ago Closed 4 years ago

Bug 1059255 broke the stdc++ compat test

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set

Tracking

(firefox40 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

0001-Bug-1154122-Fix-stdc-compat-check-after-bug-1059255.patch
1.69 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
The patch that landed addressed bug 1059255 comment 37, but it turns out this just broke the test. The original patch does work as expected, so I'll just backout the landed patch and actually land the r+ed patch.
Carrying over r+.

Let's laugh when try tells we've introduced unwanted symbols.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=51c8780ab402
Attachment #8592017 - Flags: review+
Happily surprised it didn't blow up on try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e17f5910da75
https://hg.mozilla.org/mozilla-central/rev/e17f5910da75
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.