Closed Bug 1154134 Opened 9 years ago Closed 9 years ago

APZ wheel scrolling doesn't factor in whether vertical scrolling is allowed

Categories

(Core :: Panning and Zooming, defect)

Product:
Core
Component:
Panning and Zooming
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(1 file)

fix
2.76 KB, patch
kats
: review+
Details | Diff | Splinter Review 
When we originally added FrameMetrics::AllowVerticalScrollWithWheel, we relied on APZC's internal's overscroll handoff. Now, wheel scrolling no longer uses that, and instead relies entirely on CanScroll(). So, CanScroll() needs to check this flag.
Attached patch fix — — Splinter Review 

        Attachment #8592039 -
        Flags: review?(bugmail.mozilla)

        Attachment #8592039 -
        Flags: review?(bugmail.mozilla) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3cbeb491bf8f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox40:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: