1154195 - [System] split the visual from browser_context_menu.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

Before applying the TV visual, we should split the visual part from browser_context_menu. After that, we can apply TV visual with TV build.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

I found a redundant function called isVisible() in browser_context_menu. The logic is totally the same as isShown() of BasedUI. I will remove it and change the function call of isVisible() to isShown().

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] huchengtw-moz:bug-1154195-split-context-menu-ui > mozilla-b2g:master

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8592641 [details] [review]
[gaia] huchengtw-moz:bug-1154195-split-context-menu-ui > mozilla-b2g:master

This patch split the view of browser context menu to context_menu_view. We will use bug 1154607 to pack it as base module and use it in AppWindow. After these two bugs, we will use bug 1154200 to support TV visual.

Please review this patch.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8592641 [details] [review]
[gaia] huchengtw-moz:bug-1154195-split-context-menu-ui > mozilla-b2g:master

GU22 is failed please fix it.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/85a30ac26350824b464afe144a2dc44629bc8945

tree herder is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=5e5197d44a1dc4250f3dfc05c705199320a973c1