1154389 - Stop leaking DeviceSuccessCallbackRunnable objects, and release its mOnSuccess and mOnFailure on the main thread if needed

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Comment 1

[(no longer active)]

Attachment: Stop leaking DeviceSuccessCallbackRunnable objects, and release its mOnSuccess and mOnFailure on the main thread if needed

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8592342 [details] [diff] [review]
Stop leaking DeviceSuccessCallbackRunnable objects, and release its mOnSuccess and mOnFailure on the main thread if needed

Review of attachment 8592342 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/MediaManager.cpp
@@ +1510,5 @@
>        }
>      }
>      // In the case of failure with this newly allocated runnable, we
>      // intentionally leak the runnable, because we've pawned mOnSuccess and
>      // mOnFailure onto it which are main thread objects unsafe to release here.

update the comment

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/3b67e84d534e because I had to back out bug 1153304 for bustage:

https://treeherder.mozilla.org/logviewer.html#?job_id=8847436&repo=mozilla-inbound

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

See alternative idea in this other bug.

Comment 5

[(no longer active)]

Pushed a fixed version.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/86b24496b3a8