Stop leaking DeviceSuccessCallbackRunnable objects, and release its mOnSuccess and mOnFailure on the main thread if needed

RESOLVED FIXED in Firefox 40

Status

()

Core
WebRTC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8592342 [details] [diff] [review]
Stop leaking DeviceSuccessCallbackRunnable objects, and release its mOnSuccess and mOnFailure on the main thread if needed
Attachment #8592342 - Flags: review?(rjesup)
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan
Blocks: 1153304
Comment on attachment 8592342 [details] [diff] [review]
Stop leaking DeviceSuccessCallbackRunnable objects, and release its mOnSuccess and mOnFailure on the main thread if needed

Review of attachment 8592342 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/MediaManager.cpp
@@ +1510,5 @@
>        }
>      }
>      // In the case of failure with this newly allocated runnable, we
>      // intentionally leak the runnable, because we've pawned mOnSuccess and
>      // mOnFailure onto it which are main thread objects unsafe to release here.

update the comment
Attachment #8592342 - Flags: review?(rjesup) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/3b67e84d534e because I had to back out bug 1153304 for bustage:

https://treeherder.mozilla.org/logviewer.html#?job_id=8847436&repo=mozilla-inbound
Flags: needinfo?(ehsan)
See alternative idea in this other bug.
See Also: → bug 1154337
(Assignee)

Comment 5

3 years ago
Pushed a fixed version.
Flags: needinfo?(ehsan)
https://hg.mozilla.org/mozilla-central/rev/86b24496b3a8
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.