1154436 - Many "Sending message that cannot be cloned. Are you trying to send an XPCOM object?" test failures

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Dave Townsend [:mossop]]

I was a little surprised when JPM tests passed first time with the patch in bug 1152382 so maybe I should have checked cfx which was failing in a bunch of places.

Comment 1

[Dave Townsend [:mossop]]

Attachment: pull request

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Dave Townsend [:mossop] from comment #0)
> I was a little surprised when JPM tests passed first time with the patch in
> bug 1152382 so maybe I should have checked cfx which was failing in a bunch
> of places.

It loos like the errors are coming from the e10s-content add-on which should be running on travis, and appears to have passed there, now I'm confused why that would be.  Any idea Dave?

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/c35a65234594796588d20f6235c143bb1605c342
Bug 1154436: Fix unclonable message passing. r=erikvold

Comment 4

[Dave Townsend [:mossop]]

Yeah I'm a bit confused. The pull request that should have introduced the errors passed cleanly: https://travis-ci.org/mozilla/addon-sdk/builds/58003769. But then a later pull requests shows all the same errors as jpm: https://travis-ci.org/mozilla/addon-sdk/builds/58966494. Unless travis is managing to test the wrong code which seems unlikely I can't think of why this would be.