Closed Bug 1154480 Opened 5 years ago Closed 5 years ago

Make new Uint8Array().set([], -1) throw a RangeError, not merely an Error

Categories

(Core :: JavaScript: Standard Library, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

References

Details

Attachments

(1 file)

This patch is based upon bug 1140752's patch, so sort of depends on it, but I could reorder the two easily enough.  The C++ version and the self-hosted version currently up to land both throw an Error in this case.  I'd really rather keep the two in sync, for general sanity, not fix each at separate times.
Attached patch PatchSplinter Review
The XDR bump is somewhat precautionary -- I didn't quite change anything burned into bytecode.  But the semantic change exists nonetheless, so it seems prudent, even if off the top of my head I can't think of a reason that this patch *requires* it.
Attachment #8592486 - Flags: review?(till)
Comment on attachment 8592486 [details] [diff] [review]
Patch

Review of attachment 8592486 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8592486 - Flags: review?(till) → review+
https://hg.mozilla.org/mozilla-central/rev/7256214748a5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.