1154482 - about:webrtc page occasionally throws a TypeError for an undefined reference

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P3)

Description

[Paul Kerr [:pkerr]]

TypeError: c is undefined" inside candidateToString(c)

Comment 1

[Paul Kerr [:pkerr]]

Attachment: about:webrtc intermittently throws a js type error

Comment 2

[Paul Kerr [:pkerr]]

Attachment: about:webrtc intermittently throws a js type error

with less whitespace

Comment 3

[Paul Kerr [:pkerr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2e77b00f4c4

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d2e77b00f4c4

Comment 5

[Maire Reavy [:mreavy]]

Paul -- Can you write an uplift request for this to Fx38 and Fx39?  And can you file a follow up bug (linked to this one) to investigate the root cause of the TypeError?  Thanks.

Comment 6

[Paul Kerr [:pkerr]]

Root cause bug: 1155255.

Comment 7

[Paul Kerr [:pkerr]]

Comment on attachment 8592511 [details] [diff] [review]
about:webrtc intermittently throws a js type error

Approval Request Comment
[Feature/regressing bug #]: this bug: 1154482
[User impact if declined]: Testers and early adopters of WebRTC will occasionally see a Javascript TypeError instead of WebRTC internal state data when using the about:webrtc to debug issues.
[Describe test coverage new/current, TreeHerder]: Manual testing was conducted to verify that the function in question now correctly handled null/undefined values. No new automated test was created as the actual root cause of the corrupted data is unknown at this point. Current TreeHerder tests show no regressions cause by this patch.
[Risks and why]: This is a very low risk change; it is a simple if() statement in a single javascript file. It allows the remainder of the uncorrupted data to be displayed to the user.
[String/UUID change made/needed]: none

Comment 8

[Paul Kerr [:pkerr]]

Comment on attachment 8592511 [details] [diff] [review]
about:webrtc intermittently throws a js type error

Approval Request Comment
[Feature/regressing bug #]: this bug: 1154482
[User impact if declined]: Testers and early adopters of WebRTC will occasionally see a Javascript TypeError instead of WebRTC internal state data when using the about:webrtc to debug issues. This issue was first reported by a beta user.
[Describe test coverage new/current, TreeHerder]: Manual testing was conducted to verify that the function in question now correctly handled null/undefined values. No new automated test was created as the actual root cause of the corrupted data is unknown at this point. Current TreeHerder tests show no regressions cause by this patch.
[Risks and why]: This is a very low risk change; it is a simple if() statement in a single javascript file. It allows the remainder of the uncorrupted data to be displayed to the user.
[String/UUID change made/needed]: none

Comment 9

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8592511 [details] [diff] [review]
about:webrtc intermittently throws a js type error

Approved for uplift to 39 as this looks like a minor change to improve error message accuracy.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fb10a430555d

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8592511 [details] [diff] [review]
about:webrtc intermittently throws a js type error

Just like Liz said
Should be in 38 beta 6.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/899ee022ed4c