Open Bug 1154519 Opened 9 years ago Updated 2 years ago

Serialize nsIWebBrowserPrint properties to PrintData for OS X and GTK

Categories

(Toolkit :: Printing, defect)

Product:
Toolkit
Component:
Printing
Version:
36 Branch
Platform:
x86
All
Type:
defect

Tracking

()

People

(Reporter: mconley, Unassigned)

References

Details

A patch in bug 1152921 plugs a crash where we were sending uninitialized data over IPC. The uninitialized data was in the PrintData struct - specifically, it was the nsIWebBrowserPrint properties that the Windows printing prompt needs. The OS X and Linux printing prompts do not need these properties, so they were left uninitialized. dbaron's patch initializes these boolean values to false.

We might as well just pass in the nsIWebBrowserPrint properties, even if GTK and OS X aren't consuming them. That'd probably make the most sense.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.