If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add the ability to notify timeouts to MediaTestManager

RESOLVED FIXED in Firefox 40

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8592597 [details] [diff] [review]
1154564_notify_timeouts-v1.patch
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Comment on attachment 8592597 [details] [diff] [review]
1154564_notify_timeouts-v1.patch

Review of attachment 8592597 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/test/manifest.js
@@ +925,5 @@
>    }
>  
>    // Registers that the test corresponding to 'token' has been started.
>    // Don't call more than once per token.
> +  this.started = function(token, handler) {

Take an optional handler to notify unfinished tests when the test case times out. This allows the unfinished tests to report details about the timeout.

::: dom/media/test/test_playback.html
@@ +35,5 @@
> +    "ontimeout": function() {
> +      Log(token, "timed out: ended=" + v.seenEnded + ", suspend=" + v.seenSuspend);
> +    }
> +  };
> +  manager.started(token, handler);

Report event status in the handler and remove the usage of flaky setTimeout().
Attachment #8592597 - Flags: review?(cpearce)
Attachment #8592597 - Flags: review?(cpearce) → review+
(Assignee)

Comment 3

3 years ago
Thanks for the super fast review!
(Assignee)

Comment 4

3 years ago
inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/0e73400d9c1c
https://hg.mozilla.org/mozilla-central/rev/0e73400d9c1c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.