1154646 - Mobile about:config determines pref existence incorrectly

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Capella [:capella]]

This is a good second or third bug for anyone who's already completed a change to Mobile FF, and has a working knowledge of Javascript.

There's two places in our about:config editor where we make a "pref-is-new? y/n" check [1], and [2]

Unfortunately, we're currently checking the dynamic document-list of items currently displayed, and we should be checking the internal global-list.

Both checks need to be modified to make the correct decision. The change at [1] just requires the invalid check to be corrected.

The change at [2] will involve an additional logic change. Currently the flow is:
   if (!pref-is-in-list) {
      // reload global-list and exit
   }
   // change item in document-list and fall-through

It needs to be changed to reflect:
   if (pref-in-document-list) {
      // change item in document-list and exit
   }
   if (!pref-in-global-list) {
      // reload global-list and exit
   }
   // Pref already in global list, will update document list
   // later, fall-through, do nothing for now


[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/config.js?rev=3bdce03e9ec0&mark=90-90#80
[2] http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/config.js?rev=3bdce03e9ec0&mark=475-475#459

Comment 1

[Mark Capella [:capella]]

Attachment: bug1154646.diff

This is annoying - let's fix it.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8598631 [details] [diff] [review]
bug1154646.diff

Review of attachment 8598631 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/config.js
@@ +491,2 @@
>        document.location.reload();
>        return;

I guess you don't need this return now.

Comment 3

[Mark Capella [:capella]]

Aha! Good eye!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b78d3c9515f0

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9ff07e7be3c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b9ff07e7be3c