1154681 - Use static lookup in errors.py

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Andreas Tolfsen ❲:ato❳]

errors.lookup currently iterates using anonymous functions every time you do a lookup.  This is inefficient and better practice would be to use a pre-defined lookup table.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: bz://1154681/ato

/r/7353 - Bug 1154681: Use static lookups in errors.py

Pull down this commit:

hg pull -r 93e29eb4cc59299ce873edd781e097e39c8ed529 https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f89af688aa92

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8595310 [details]
MozReview Request: bz://1154681/ato

https://reviewboard.mozilla.org/r/7351/#review6111

Ship It!

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8595310 [details]
MozReview Request: bz://1154681/ato

/r/7353 - Bug 1154681: Use static lookups in errors.py

Pull down this commit:

hg pull -r 9840c07fa813f7b44ea305669683efffd2dfe94c https://reviewboard-hg.mozilla.org/gecko/

Comment 5

[James Graham [:jgraham]]

Comment on attachment 8595310 [details]
MozReview Request: bz://1154681/ato

https://reviewboard.mozilla.org/r/7351/#review6113

::: testing/marionette/driver/marionette_driver/errors.py:186
(Diff revision 2)
> -    by_code = lambda exc: identifier in exc.code
> +    lookup = None

I'm not really sure that setting lookup to None here helps; I would just raise a ValueError in an "else" clause below.

Comment 6

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8595310 [details]
MozReview Request: bz://1154681/ato

/r/7353 - Bug 1154681: Use static lookups in errors.py

Pull down this commit:

hg pull -r 990d55c253c89f822557023676f84371b3dfb3df https://reviewboard-hg.mozilla.org/gecko/

Comment 7

[Andreas Tolfsen ❲:ato❳]

https://reviewboard.mozilla.org/r/7351/#review6119

> I'm not really sure that setting lookup to None here helps; I would just raise a ValueError in an "else" clause below.

Actually I've changed it so that it defaults to `by_string` so that in case where `identifier` is unknown, it will always end up returning `MarionetteException`.

Comment 8

[James Graham [:jgraham]]

Comment on attachment 8595310 [details]
MozReview Request: bz://1154681/ato

https://reviewboard.mozilla.org/r/7351/#review6121

Ship It!

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d90c697eead2

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d90c697eead2

Comment 12

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1154681: Use static lookups in errors.py

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Moving bugs for Marionette client due to component changes.