Closed Bug 1154691 Opened 10 years ago Closed 10 years ago

Align Marionette errors with WebDriver errors

Categories

(Testing :: Marionette Client and Harness, defect)

Product:
Testing
Component:
Marionette Client and Harness
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

(Keywords: pi-marionette-client, pi-marionette-server)

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1154691: Align Marionette with WebDriver errors
39 bytes, text/x-review-board-request
automatedtester
: review+
Details
The list of errors in errors.py is out of date with the ones mandated by the W3C WebDriver specification. Since the server is now _mostly_ up to date, it's time to align the Python client exceptions as well.
We're also missing InvalidSelectorError and InvalidSessionError in the server. We can do these as part of this patch as well.
Keywords: ateam-marionette-client, ateam-marionette-server
Summary: Align exceptions in errors.py with WebDriver errors → Align Marionette errors with WebDriver errors
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f436169871a3
Assignee: nobody → ato
Status: NEW → ASSIGNED
Attached file MozReview Request: bz://1154691/ato (obsolete) —
/r/7065 - Bug 1154691: Align Marionette with WebDriver errors Pull down this commit: hg pull -r 77d48ec0d5c1027ce4897d25871f78b887b2779b https://reviewboard-hg.mozilla.org/gecko/
Comment on attachment 8592782 [details] MozReview Request: bz://1154691/ato /r/7065 - Bug 1154691: Align Marionette with WebDriver errors Pull down this commit: hg pull -r 77d48ec0d5c1027ce4897d25871f78b887b2779b https://reviewboard-hg.mozilla.org/gecko/
Attachment #8592782 - Flags: review?(dburns)
Comment on attachment 8592782 [details] MozReview Request: bz://1154691/ato https://reviewboard.mozilla.org/r/7063/#review5873 ::: testing/marionette/error.js (Diff revision 1) > + this.code = 13; this should be 32 so that it can be picked up by https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver/marionette_driver/errors.py#142
Attachment #8592782 - Flags: review?(dburns)
Comment on attachment 8592782 [details] MozReview Request: bz://1154691/ato /r/7065 - Bug 1154691: Align Marionette with WebDriver errors Pull down this commit: hg pull -r 5a39fe5749190acb2170025586e6bfdd82e5697c https://reviewboard-hg.mozilla.org/gecko/
Attachment #8592782 - Flags: review?(dburns)
Attachment #8592782 - Flags: review?(dburns) → review+
Comment on attachment 8592782 [details] MozReview Request: bz://1154691/ato https://reviewboard.mozilla.org/r/7063/#review5887 Ship It!
Pushed again to inbound, as gaia has now been bumped: https://hg.mozilla.org/integration/mozilla-inbound/rev/c7eea3e8f98a
jgraham landed the update to wptrunner in http://hg.mozilla.org/integration/mozilla-inbound/rev/07169eaa246e.
(In reply to Andreas Tolfsen (:ato) from comment #16) > Pushed to inbound again: > https://hg.mozilla.org/integration/mozilla-inbound/rev/330f6df11b2f sorry had to back this out again for a backout of bug 1153832 that include some file conflicts without backing this here out
Flags: needinfo?(ato)
https://hg.mozilla.org/mozilla-central/rev/07169eaa246e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Flags: needinfo?(ato)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/9a56491b7588
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Attachment #8592782 - Attachment is obsolete: true
Attachment #8620047 - Flags: review+
Product: Testing → Remote Protocol

Moving bugs for Marionette client due to component changes.

Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: