Closed
Bug 1154717
Opened 10 years ago
Closed 10 years ago
Fix toLocalTimeISOString()
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox38 | --- | unaffected |
firefox39 | --- | fixed |
firefox40 | --- | fixed |
People
(Reporter: gfritzsche, Assigned: gfritzsche)
References
Details
Attachments
(1 file, 1 obsolete file)
1.58 KB,
patch
|
Yoric
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 1149284 disabled test_TelemetrySession.js since end of May, which dropped under our radar and means we missed test-coverage for some changes.
This fixed toLocalTimeISOString() failures when re-enabling it.
Attachment #8592813 -
Flags: review?(dteller)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 1•10 years ago
|
||
Comment on attachment 8592813 [details] [diff] [review]
Fix toLocalTimeISOString()
Review of attachment 8592813 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/telemetry/TelemetrySession.jsm
@@ +259,5 @@
> + "T" + padNumber(date.getHours(), 2)
> + ":" + padNumber(date.getMinutes(), 2)
> + ":" + padNumber(date.getSeconds(), 2)
> + "." + date.getMilliseconds()
> + + sign(tzOffset) + padNumber(Math.abs(Math.floor(tzOffset / 60)), 2)
Are you sure it's `Math.abs(Math.floor(...))` and not `Math.floor(Math.abs(...))`?
Attachment #8592813 -
Flags: review?(dteller)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8592813 -
Attachment is obsolete: true
Attachment #8593397 -
Flags: review?(dteller)
Comment 3•10 years ago
|
||
Comment on attachment 8593397 [details] [diff] [review]
Fix toLocalTimeISOString()
Review of attachment 8593397 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me. Any chance you could add a test?
Attachment #8593397 -
Flags: review?(dteller) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Checked as part of this try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8782360b606
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•10 years ago
|
status-firefox38:
--- → unaffected
status-firefox39:
--- → affected
Comment 7•10 years ago
|
||
Comment on attachment 8593397 [details] [diff] [review]
Fix toLocalTimeISOString()
Approved for Aurora. For approval request see bug 1139460 comment 42. For approval comments see bug 1139460 comment 43.
Attachment #8593397 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 8•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•