1154717 - Fix toLocalTimeISOString()

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Georg Fritzsche [:gfritzsche]]

Attachment: Fix toLocalTimeISOString()

Bug 1149284 disabled test_TelemetrySession.js since end of May, which dropped under our radar and means we missed test-coverage for some changes.

This fixed toLocalTimeISOString() failures when re-enabling it.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8592813 [details] [diff] [review]
Fix toLocalTimeISOString()

Review of attachment 8592813 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetrySession.jsm
@@ +259,5 @@
>      + "T" + padNumber(date.getHours(), 2)
>      + ":" + padNumber(date.getMinutes(), 2)
>      + ":" + padNumber(date.getSeconds(), 2)
>      + "." + date.getMilliseconds()
> +    + sign(tzOffset) + padNumber(Math.abs(Math.floor(tzOffset / 60)), 2)

Are you sure it's `Math.abs(Math.floor(...))` and not `Math.floor(Math.abs(...))`?

Comment 2

[Georg Fritzsche [:gfritzsche]]

Attachment: Fix toLocalTimeISOString()

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8593397 [details] [diff] [review]
Fix toLocalTimeISOString()

Review of attachment 8593397 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Any chance you could add a test?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/fe5714bb1a43

Comment 5

[Georg Fritzsche [:gfritzsche]]

Checked as part of this try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8782360b606

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fe5714bb1a43

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8593397 [details] [diff] [review]
Fix toLocalTimeISOString()

Approved for Aurora. For approval request see bug 1139460 comment 42. For approval comments see bug 1139460 comment 43.

Comment 8

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3b81354f6a5b