1154800 - [Status Bar] OTA Download Icons can linger on homescreen after canceling download

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150415_0904.txt

Description:
When the user is downloading the OTA to update their phone, they may observe that after canceling the update, the phone may not redraw the status bar and leave the icons lingering on the display. This issue seemed to be experienced more often when the user cancels the OTA from within an app, such as Settings, where the icons will remain open in that app as well as when the user returns to homescreen.

Repro Steps:
1) Update a Flame to 20150413010203
2) Connect to a Wi-Fi connection
3) Navigate to Settings
4) Locate an OTA update: begin download
5) Swipe down Notification Tray
6) Tap active download for OTA
7) Cancel download
8) Observe status bar

Actual:
Status Bar icons for OTA update remain after cancel: does not draw away

Expected:
Status Bar does not display icons for OTA download after canceling download


Environmental Variables:
--------------------------------------------------
Device: Flame 3.0
Build ID: 20150413010203
Gaia: 3c68964cb9fdba7cf0f6829b7f44562acaf1f1d7
Gecko: 0a46652bd992
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

--------------------------------------------------
Issue has different results for similar actions in flame 2.2 devices
Results: Status Bar icons don't draw icons for OTA update when beginning download

Device: Flame 2.2
BuildID: 20150413002502
Gaia: cec00d643f517ffd96cde559cd3bbd43ab85816c
Gecko: 5005522fd68e
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
--------------------------------------------------
Issue DOES NOT REPRO 2.1 for flame devices; different UX
Results: Status Bar does not update in apps for OTA update (not drawn in apps; only homescreen & notification tray)

Device: Flame 2.1
BuildID: 20150413001204
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: a1b2434ad001
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
--------------------------------------------------



Repro frequency: 3/10
Link to failed test case:
video- https://youtu.be/h7WJZsZrd1c
logcat

Comment 1

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision and assignment.

Comment 2

[Hermes Cheng (inactive after July 27, 2015)]

Michael, could you take a look?

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Guillaume, can you see what's happening?

Comment 4

[Guillaume Marty [:gmarty]]

[Blocking Requested - why for this release]:

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1154800-OTA-Download-Icons-can-linger-on-homescreen-after-canceling-download > mozilla-b2g:master

Comment 6

[Guillaume Marty [:gmarty]]

Comment on attachment 8596568 [details] [review]
[gaia] gmarty:Bug-1154800-OTA-Download-Icons-can-linger-on-homescreen-after-canceling-download > mozilla-b2g:master

Etienne, here is the patch we discussed. Can you review it?

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Should be a blocker.

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8596568 [details] [review]
[gaia] gmarty:Bug-1154800-OTA-Download-Icons-can-linger-on-homescreen-after-canceling-download > mozilla-b2g:master

Thanks!

Comment 9

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#SNLiaj0zTkK2RcQ_JkgJuA

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 10

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/06ec6f521da5fb535f647f94b47ef82b784344c7

Comment 11

[Guillaume Marty [:gmarty]]

Comment on attachment 8596568 [details] [review]
[gaia] gmarty:Bug-1154800-OTA-Download-Icons-can-linger-on-homescreen-after-canceling-download > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Status bar
[User impact] if declined: The status bar can go in an inconsistent mode where it is frozen when minimised.
[Testing completed]: This patch is well tested, but manual testing is needed
[Risk to taking this patch] (and alternatives if risky): Low as the patch is minimal and unit tested.
[String changes made]: None.

Comment 12

[bhavana bajaj [:bajaj]]

Comment on attachment 8596568 [details] [review]
[gaia] gmarty:Bug-1154800-OTA-Download-Icons-can-linger-on-homescreen-after-canceling-download > mozilla-b2g:master

Thanks for the test, approving for 2.2 landing.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/9f6b1b9082662ba2c14168fc66bb02b4df3141e5

Comment 14

[Jamie Charlton (:Jamie_)]

The icon of downloading OTA is no longer displayed when the download is canceled.

2.2
Environmental Variables:
Device: Flame 2.2
Build ID: 20150428002500
Gaia: 9f6b1b9082662ba2c14168fc66bb02b4df3141e5
Gecko: e79c19bf19bf
Gonk: Could not pull gonk.  Did you shallow Flash?
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

3.0
Device: Flame 3.0
Build ID: 20150424010200
Gaia: 0c5e2ee1173f3c53379ef3cd10de714836258fe8
Gecko: 22a157f7feb7
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 40.0a1 (3.0)
Firmware Version: v18D_nightly_v2
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0