1154812 - worker location.pathname returns incorrect value

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It's returning the .path of the nsIURI, but the diagram in nsIURI makes it very clear that this is everything starting with the '/' after the hostport.  So it includes the query and ref, for example, whereas pathname is not supposed to include those.

nsLocation uses nsIURL GetFilePath here.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix location.pathname to return the right thing in workers

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix location.pathname to return the right thing in workers

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix location.pathname to return the right thing in workers

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8592923 [details] [diff] [review]
Fix location.pathname to return the right thing in workers

Review of attachment 8592923 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsContentUtils.h
@@ +2281,5 @@
>     * If the hostname for aURI is an IPv6 it encloses it in brackets,
>     * otherwise it just outputs the hostname in aHost.
>     */
>    static void GetHostOrIPv6WithBrackets(nsIURI* aURI, nsAString& aHost);
> +  static void GetHostOrIPv6WithBrackets(nsIURI* aURI, nsCString& aHost);

nsACString ?

Comment 5

[Boris Zbarsky [:bzbarsky]]

>nsACString ?

I made it nsCString on purpose so the nsAString version can just pass in the string to use instead of ending up copying twice.  I can add a comment to that effect if that would help.

Comment 6

[Andrea Marchesini [:baku]]

ok.

Comment 7

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3fb858ffea7c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3fb858ffea7c