Is ruby `text-emphasis: none` redundant?

RESOLVED FIXED in Firefox 38

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: marcosc, Assigned: xidorn)

Tracking

Trunk
mozilla40
Points:
---

Firefox Tracking Flags

(firefox38 fixed, firefox39 fixed, firefox40 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
When debugging, I keep seeing: 

INFO Console message: [JavaScript Warning: "Unknown property 'text-emphasis'.  Declaration dropped." {file: "resource://gre-resources/html.css" line: 807 column: 17 source: "    text-emphasis: none;"}]

Can we drop that line from html.css?
(Reporter)

Updated

3 years ago
Flags: needinfo?(quanxunzhen)
(Reporter)

Comment 1

3 years ago
the context is:

  rt {
    display: ruby-text;
    font-variant-east-asian: ruby;
    text-emphasis: none;
  }
Given that we haven't support text-emphasis yet, then yes we should remove this line. And as it produces annoying console message, we should uplift the removal to beta.
Depends on: 1040668
Flags: needinfo?(quanxunzhen)
Created attachment 8593074 [details] [diff] [review]
patch
Assignee: nobody → quanxunzhen
Attachment #8593074 - Flags: review?(cam)
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Comment on attachment 8593074 [details] [diff] [review]
patch

Review of attachment 8593074 [details] [diff] [review]:
-----------------------------------------------------------------

Why do we have rules like "rtc, rt" rather than "ruby > rtc, ruby > rt, rtc > rt" like the spec has?
We probably should ask the spec to rollback that change.

We decided in bug 1135306 that description in HTML5 doesn't make sense to rendering behavior, hence we don't need to change the stylesheet to match its description, which means the style sheet in the ruby spec could also remain to be simple.
Attachment #8593074 - Flags: review?(cam) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c46e5b8fb2f0
https://hg.mozilla.org/mozilla-central/rev/c46e5b8fb2f0
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment on attachment 8593074 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1039006
[User impact if declined]: See "Unknown property 'text-emphasis'.  Declaration dropped." in browser console
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: no risk, just a simple fix on html.css
[String/UUID change made/needed]: n/a
Attachment #8593074 - Flags: approval-mozilla-beta?
Attachment #8593074 - Flags: approval-mozilla-aurora?
status-firefox38: --- → affected
status-firefox39: --- → affected
Comment on attachment 8593074 [details] [diff] [review]
patch

Should be in 38 beta 5.
Attachment #8593074 - Flags: approval-mozilla-beta?
Attachment #8593074 - Flags: approval-mozilla-beta+
Attachment #8593074 - Flags: approval-mozilla-aurora?
Attachment #8593074 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/c4361659651c
status-firefox39: affected → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/8fd05ce16a5f
status-firefox38: affected → fixed
You need to log in before you can comment on or make changes to this bug.