1154814 - Is ruby `text-emphasis: none` redundant?

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Marcos Caceres [:marcosc]]

When debugging, I keep seeing: 

INFO Console message: [JavaScript Warning: "Unknown property 'text-emphasis'.  Declaration dropped." {file: "resource://gre-resources/html.css" line: 807 column: 17 source: "    text-emphasis: none;"}]

Can we drop that line from html.css?

Comment 1

[Marcos Caceres [:marcosc]]

the context is:

  rt {
    display: ruby-text;
    font-variant-east-asian: ruby;
    text-emphasis: none;
  }

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Given that we haven't support text-emphasis yet, then yes we should remove this line. And as it produces annoying console message, we should uplift the removal to beta.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8593074 [details] [diff] [review]
patch

Review of attachment 8593074 [details] [diff] [review]:
-----------------------------------------------------------------

Why do we have rules like "rtc, rt" rather than "ruby > rtc, ruby > rt, rtc > rt" like the spec has?

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

We probably should ask the spec to rollback that change.

We decided in bug 1135306 that description in HTML5 doesn't make sense to rendering behavior, hence we don't need to change the stylesheet to match its description, which means the style sheet in the ruby spec could also remain to be simple.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c46e5b8fb2f0

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c46e5b8fb2f0

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8593074 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1039006
[User impact if declined]: See "Unknown property 'text-emphasis'.  Declaration dropped." in browser console
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: no risk, just a simple fix on html.css
[String/UUID change made/needed]: n/a

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8593074 [details] [diff] [review]
patch

Should be in 38 beta 5.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c4361659651c

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8fd05ce16a5f