[Desktop][Yahoo Mail] Color selection indicator not working correctly for highlight text

ASSIGNED
Assigned to

Status

P3
normal
ASSIGNED
3 years ago
a month ago

People

(Reporter: mellis, Assigned: amitkasat)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [country-all] [js] [sitewait] [platform-rel-Yahoo!], URL)

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Yahoo Mail desktop app: (affects both PC and Mac)

Description: The "text color" button in Yahoo mail opens up an interface which allows the user to select both text color, as well as a text highlight color.  The selected color for both is indicated by the presence of a small "check mark" within the box of the selected color.  The check mark does not move from the default "white/none" regardless of which highlighted color is selected, although the app will properly highlight according to the color last selected by the user. 

STR:
Open Yahoo mail on Desktop
Login in to account and begin composing an email 
Select a highlight color for you text and begin typing.  Notice the color is correctly being applied to the background of the text.  Now click back on the "text color" button and observe how "white" appears to remain the selected color.

Expected result:
Little check mark moves according to highlight color selected.
(Reporter)

Comment 1

3 years ago
@Amit - Would you mind taking a look at this bug and providing a comment?
Assignee: nobody → amitkasat
Status: NEW → ASSIGNED
Flags: needinfo?(amitkasat)
Priority: -- → P3

Comment 2

3 years ago
Created attachment 8593150 [details]
yahoo-mail-ui

So after testing this.
You can select a background color. (right colum of colors after clicking on square icon "A")
You can change the background color to another one.
BUT you can't activate the no color (top right icon square box.)

Comment 3

3 years ago
The markup for this section of the document.

<li id="yui_3_16_0_1_1429149802790_2701" 
    role="presentation" 
    style="background-color:transparent;" 
    title="Aucune couleur" 
    class="transparent" 
    data-value="transparent">
  <a id="yui_3_16_0_1_1429149802790_2850" 
     tabindex="-1" 
     role="menuitem" 
     class="icon icon-none"></a>
  <a id="yui_3_16_0_1_1429149802790_2766" 
     class="icon icon-checkmark" 
     tabindex="-1" 
     role="menuitem" 
     href="#"></a>
</li>


Every related to the color picker are in 
_shared_module_offscreen_bin_compose_menu_color_picker: {
            path: '_shared/module/offscreen-bin/compose/menu-color-picker_54_10489.js'
          },

The colorpicker on the left side (aka text) is working 
The colorpicker on the right side (aka background) is not working only for the no color choice.


The color clicked in the right panel seems to not be registered.
To note Opera Blink has the same issue, with a slight difference is that the checkmark is moved around.

    _colorClicked: function (a, b) {
      var c,
      d = a.target.getDOMNode(),
      e = b.type;
      'LI' !== d.nodeName && 'LI' === d.parentNode.nodeName && (d = d.parentNode),
      'LI' === d.nodeName && ('fore' === e ? (c = d.getAttribute('data-value'), this.setFontColor(c))  : 'back' === e && (c = d.getAttribute('data-value'), this.setBgColor(c)), this._hideColorPicker(b)),
      a.halt()
    },
Whiteboard: [country-all] [js]

Updated

3 years ago
Whiteboard: [country-all] [js] → [country-all] [js] [sitewait]
(Assignee)

Comment 4

3 years ago
Michael/Karl,

We are using native selection functions to get the background color of selected text

document.queryCommandValue("backColor");

This always returns 'transparent' in Firefox. I also tried using document.queryCommandValue("hiliteColor"); but event that does not work.

Any suggestions?

Thanks,
Amit
Flags: needinfo?(amitkasat)
I filed bug 1183844 to track this incorrect behaviour.

Updated

2 years ago
platform-rel: --- → ?

Updated

2 years ago
Whiteboard: [country-all] [js] [sitewait] → [country-all] [js] [sitewait] [platform-rel-Yahoo!]
platform-rel: ? → ---
Depends on: 1183844
The issue is still reproducible both on Firefox Nightly 63.0a1 (2018-07-04)and Chrome 67.0.3396.99.

[Tested with:]
Operating System: Windows 10 Pro
You need to log in before you can comment on or make changes to this bug.