1154830 - [Desktop][Yahoo Mail] Color selection indicator not working correctly for highlight text

Status: ASSIGNED

(Web Compatibility :: Site Reports, defect, P3)

Description

[Michael Ellis]

Yahoo Mail desktop app: (affects both PC and Mac)

Description: The "text color" button in Yahoo mail opens up an interface which allows the user to select both text color, as well as a text highlight color.  The selected color for both is indicated by the presence of a small "check mark" within the box of the selected color.  The check mark does not move from the default "white/none" regardless of which highlighted color is selected, although the app will properly highlight according to the color last selected by the user. 

STR:
Open Yahoo mail on Desktop
Login in to account and begin composing an email 
Select a highlight color for you text and begin typing.  Notice the color is correctly being applied to the background of the text.  Now click back on the "text color" button and observe how "white" appears to remain the selected color.

Expected result:
Little check mark moves according to highlight color selected.

Comment 1

[Michael Ellis]

@Amit - Would you mind taking a look at this bug and providing a comment?

Comment 2

[Karl Dubost💡 :karlcow]

Attachment: yahoo-mail-ui

So after testing this.
You can select a background color. (right colum of colors after clicking on square icon "A")
You can change the background color to another one.
BUT you can't activate the no color (top right icon square box.)

Comment 3

[Karl Dubost💡 :karlcow]

The markup for this section of the document.

<li id="yui_3_16_0_1_1429149802790_2701" 
    role="presentation" 
    style="background-color:transparent;" 
    title="Aucune couleur" 
    class="transparent" 
    data-value="transparent">
  <a id="yui_3_16_0_1_1429149802790_2850" 
     tabindex="-1" 
     role="menuitem" 
     class="icon icon-none"></a>
  <a id="yui_3_16_0_1_1429149802790_2766" 
     class="icon icon-checkmark" 
     tabindex="-1" 
     role="menuitem" 
     href="#"></a>
</li>


Every related to the color picker are in 
_shared_module_offscreen_bin_compose_menu_color_picker: {
            path: '_shared/module/offscreen-bin/compose/menu-color-picker_54_10489.js'
          },

The colorpicker on the left side (aka text) is working 
The colorpicker on the right side (aka background) is not working only for the no color choice.


The color clicked in the right panel seems to not be registered.
To note Opera Blink has the same issue, with a slight difference is that the checkmark is moved around.

    _colorClicked: function (a, b) {
      var c,
      d = a.target.getDOMNode(),
      e = b.type;
      'LI' !== d.nodeName && 'LI' === d.parentNode.nodeName && (d = d.parentNode),
      'LI' === d.nodeName && ('fore' === e ? (c = d.getAttribute('data-value'), this.setFontColor(c))  : 'back' === e && (c = d.getAttribute('data-value'), this.setBgColor(c)), this._hideColorPicker(b)),
      a.halt()
    },

Comment 4

[Amit Kasat]

Michael/Karl,

We are using native selection functions to get the background color of selected text

document.queryCommandValue("backColor");

This always returns 'transparent' in Firefox. I also tried using document.queryCommandValue("hiliteColor"); but event that does not work.

Any suggestions?

Thanks,
Amit

Comment 5

[:Harald Kirschner :digitarald]

I filed bug 1183844 to track this incorrect behaviour.

Comment 6

[Oana Arbuzov [:oanaarbuzov]]

The issue is still reproducible both on Firefox Nightly 63.0a1 (2018-07-04)and Chrome 67.0.3396.99.

[Tested with:]
Operating System: Windows 10 Pro

Comment 7

[Firefox Bug Husbandry Bot]

See bug 1547409. Moving webcompat whiteboard tags to keywords.

Comment 8

[Oana Arbuzov [:oanaarbuzov]]

If I select a "Highlight color" (e.g blue) and start typing, the text is correctly highlighted.
If I open the color picker again and select a different "Highlight color" (e.g red) I have the following results:

• if I open the color picker again, the selected highlight color is not updated with the new one https://prnt.sc/QYxP1bFbz48C
• if I start typing, the text is correctly highlighted, and opening the color picker the highlight color is updated https://prnt.sc/0-VFJHegggzl
• if I refresh the page and open the color picker, the highlight color is white https://prnt.sc/-eSDS0ZXa-Sj

The same behavior is encountered on Chrome.

Tested with:
Browser / Version: Firefox Nightly 101.0a1 (2022-04-05), Chrome 100.0.4844.84
Operating System: Windows 10 Pro

Karl is there anything to be done here?

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:karlcow, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 10

[Karl Dubost💡 :karlcow]

The assignee was someone from Yahoo! who is still there according to Yahoo!
It depends on Bug 1183844

Comment 11

[Raul Bucata]

We appreciate your report. I was able to reproduce the issue following the steps to reproduce in comment8

Tested with:

Browser / Version: Firefox Release 109.0 (64-bit)/ Firefox Nightly 111.0a1 (2023-01-31) (64-bit) /Chrome Version 109.0.5414.120 (Official Build) (64-bit)
Operating System: Mac Ventura 13.1

Notes:

1. Reproducible regardless of the status of ETP.
2. Reproducible on the latest build of Firefox Nightly and Release.
3. Works as expected using :