1154892 - mozinstall fails to install on Mac with paths which contain white spaces

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Armen [:armenzg]]

Attachment: mozinstall.diff

hdutil fails if there is a space in the path to the file.
This happens for paths like this: downloads/Firefox 38.0b3.dmg

(temp)MacAir updates git:[update_testing*] $ mozinstall -d . downloads/Firefox\ 38.0b3.dmg
hdiutil: attach: extra image argument "38.0b3.dmg" - "/Users/armenzg/repos/git/build-tools/release/updates/downloads/Firefox" already specified
Usage:	hdiutil attach [options] <image>
	hdiutil attach -help
Traceback (most recent call last):
  File "/Users/armenzg/repos/git/build-tools/release/updates/temp/bin/mozinstall", line 9, in <module>
    load_entry_point('mozInstall==1.11', 'console_scripts', 'mozinstall')()
  File "/Users/armenzg/repos/git/build-tools/release/updates/temp/lib/python2.7/site-packages/mozinstall/mozinstall.py", line 318, in install_cli
    install_path = install(src, options.dest)
  File "/Users/armenzg/repos/git/build-tools/release/updates/temp/lib/python2.7/site-packages/mozinstall/mozinstall.py", line 121, in install
    install_dir = _install_dmg(src, dest)
  File "/Users/armenzg/repos/git/build-tools/release/updates/temp/lib/python2.7/site-packages/mozinstall/mozinstall.py", line 265, in _install_dmg
    subprocess.call('hdiutil detach %s -quiet' % appDir,
mozinstall.mozinstall.InstallError: Failed to install "/Users/armenzg/repos/git/build-tools/release/updates/downloads/Firefox 38.0b3.dmg (local variable 'appDir' referenced before assignment)"

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8593006 [details] [diff] [review]
mozinstall.diff

Review of attachment 8593006 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozinstall/setup.py
@@ +10,5 @@
>      description = file(os.path.join(here, 'README.md')).read()
>  except IOError:
>      description = None
>  
> +PACKAGE_VERSION = '1.12.dev0'

Forgot to ask about the 'dev0' suffix, I haven't seen that around as a convention.

Comment 2

[Armen [:armenzg]]

Pushed:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2951ed3da75d

I think I got that from using zest-releaser.

The Semantic versioning allows for it:
http://semver.org

A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version. Identifiers MUST comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]. Identifiers MUST NOT be empty. Numeric identifiers MUST NOT include leading zeroes. Pre-release versions have a lower precedence than the associated normal version. A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version. Examples: 1.0.0-alpha, 1.0.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc7a46590fbf

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fc7a46590fbf