1154902 - TelemetryEnvironment::error while initializing: TypeError: this._currentEnvironment.profile is undefined (resource://gre/modules/TelemetryEnvironment.jsm:835:6)

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Saw the following in logcat today:

I/Gecko   (11680): *************************
I/Gecko   (11680): A coding exception was thrown and uncaught in a Task.
I/Gecko   (11680): 
I/Gecko   (11680): Full message: TypeError: this._currentEnvironment.profile is undefined
I/Gecko   (11680): Full stack: EnvironmentCache.prototype._updateProfile<@resource://gre/modules/TelemetryEnvironment.jsm:835:7
I/Gecko   (11680): TaskImpl_run@resource://gre/modules/Task.jsm:314:40
I/Gecko   (11680): Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:867:23
I/Gecko   (11680): this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:746:7
I/Gecko   (11680): this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:37
I/Gecko   (11680): Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:5
I/Gecko   (11680): this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:709:7
I/Gecko   (11680): this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:671:7
I/Gecko   (11680): onSuccess@resource://gre/modules/osfile/osfile_native.jsm:63:7
I/Gecko   (11680): 
I/Gecko   (11680): *************************
W/GeckoConsole(11680): [JavaScript Error: "1429130020022	Toolkit.Telemetry	ERROR	TelemetryEnvironment::error while initializing: TypeError: this._currentEnvironment.profile is undefined (resource://gre/modules/TelemetryEnvironment.jsm:835:6) JS Stack trace: EnvironmentCache.prototype._updateProfile<@TelemetryEnvironment.jsm:835:7 < [e-mail]:314:40 < [e-mail]:867:23 < [e-mail]:746:7 < this.PromiseWalker.scheduleWalkerLoop/<@Promise-backend.js:688:37 < Promise*[e-mail]:688:5 < [e-mail]:709:7 < [e-mail]:671:7 < onSuccess@osfile_native.jsm:63:7" {file: "resource://gre/modules/Log.jsm" line: 749}]
D/GeckoHardwareUtils(11680): HardwareUtils already inited.

Comment 1

[Alessio Placitelli [:Dexter]]

This happens because in [1] we don't guard the _updateProfile call with |#ifndef MOZ_WIDGET_ANDROID| as we did on line 656.

[1] - https://hg.mozilla.org/mozilla-central/annotate/53ceefb0e1c8/toolkit/components/telemetry/TelemetryEnvironment.jsm#l664

Comment 2

[Alessio Placitelli [:Dexter]]

Attachment: bug1154902.patch

This prevents profile data updates in Telemetry on Android.

Comment 3

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8593838 [details] [diff] [review]
bug1154902.patch

Review of attachment 8593838 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetryEnvironment.jsm
@@ +663,5 @@
>  
> +  this._initTask = Promise.all([this._addonBuilder.init(),
> +#ifndef MOZ_WIDGET_ANDROID
> +                                this._updateProfile(),
> +#endif

This is hard to read.
Please use a temporary array and .push() to it for non-android builds.

Comment 4

[Georg Fritzsche [:gfritzsche]]

While we are here, can you fix this log call:
"TelemetryEnvironment::error while initializing"

This is missing the method name.

Comment 5

[Alessio Placitelli [:Dexter]]

Attachment: bug1154902.patch - v2

Comment 6

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8593850 [details] [diff] [review]
bug1154902.patch - v2

Review of attachment 8593850 [details] [diff] [review]:
-----------------------------------------------------------------

Are we missing test-coverage here?

Comment 7

[Alessio Placitelli [:Dexter]]

The profile section is not tested on android devices [1]

[1] - https://hg.mozilla.org/mozilla-central/annotate/51e3cb11a258/toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js#l285

Comment 8

[Alessio Placitelli [:Dexter]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=68f767411ca6

Comment 9

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/integration/fx-team/rev/82d81900667c

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/82d81900667c

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8593850 [details] [diff] [review]
bug1154902.patch - v2

Approved for Aurora. For approval request see bug 1139460 comment 42. For approval comments see bug 1139460 comment 43.

Comment 12

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/625de3552971