1154952 - Fix Gecko shutdown assertions, bugs, etc

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Right now we run into some assertions, bugs, etc. when Gecko is shutting down.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Remove extra free() calls on shutdown (v1)

The two free() calls free the same memory. That memory was also passed in as the data argument to GeckoStart, and the caller will again try to free that memory. We should just let the caller do the freeing.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Delete AndroidBridge on Gecko shutdown (v1)

AndroidBridge is never deleted right now. We should be good citizens and clean up.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Don't wait for sync event when Gecko is shutting down (v1)

The main thread could get stuck trying to wait for a nonexistent Gecko thread.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8593533 [details] [diff] [review]
Don't wait for sync event when Gecko is shutting down (v1)

Review of attachment 8593533 [details] [diff] [review]:
-----------------------------------------------------------------

Woo!

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8593530 [details] [diff] [review]
Remove extra free() calls on shutdown (v1)

Review of attachment 8593530 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I found this too a while back when working on the headless patch. Thanks.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a80c2504ff2f
https://hg.mozilla.org/integration/mozilla-inbound/rev/4eedefec8c95
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b840802ce90

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a80c2504ff2f
https://hg.mozilla.org/mozilla-central/rev/4eedefec8c95
https://hg.mozilla.org/mozilla-central/rev/1b840802ce90