1154972 - reuse upstream libvpx repository

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

media/libvpx/update.py does a fresh checkout of upstream libvpx every time it's run, which wastes a lot of time when testing incremental changes. Would be better to reuse a repository if there's one already there.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Don't remove upstream repo

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8593097 [details] [diff] [review]
Don't remove upstream repo

Review of attachment 8593097 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.

The fetch won't update the HEAD pointer in the current branch though, since it's only updating the remote, so I think you need an extra step to update the local branch.

Comment 3

[Matthew Gregan [:kinetik]]

(In reply to Matthew Gregan [:kinetik] from comment #2)
> The fetch won't update the HEAD pointer in the current branch though, since
> it's only updating the remote, so I think you need an extra step to update
> the local branch.

e.g. with a different repo:

% git rev-parse HEAD
cacaae7
% git fetch
   cacaae7..75a0efb  master     -> origin/master
% git rev-parse HEAD
cacaae7

But you probably want to checkout 75a0efb now.

Comment 4

[Ralph Giles (:rillian)]

Ah, you're correct that's a change in behaviour. Previously it would do a fresh clone every time so you'd get latest master if you didn't pass --commit. In practice I always use --commit, and if not I prefer taking the current state of the repo since I can mess with it manually. This also matches how the other media update scripts work, so I think it's a reasonable change.

I'll update the commit message to document the behaviour change.

Comment 5

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a60bf065716

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9a60bf065716