reuse upstream libvpx repository

RESOLVED FIXED in Firefox 40

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

Trunk
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

media/libvpx/update.py does a fresh checkout of upstream libvpx every time it's run, which wastes a lot of time when testing incremental changes. Would be better to reuse a repository if there's one already there.
(Assignee)

Comment 1

4 years ago
Created attachment 8593097 [details] [diff] [review]
Don't remove upstream repo
Attachment #8593097 - Flags: review?(kinetik)
Comment on attachment 8593097 [details] [diff] [review]
Don't remove upstream repo

Review of attachment 8593097 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.

The fetch won't update the HEAD pointer in the current branch though, since it's only updating the remote, so I think you need an extra step to update the local branch.
Attachment #8593097 - Flags: review?(kinetik) → review+
(In reply to Matthew Gregan [:kinetik] from comment #2)
> The fetch won't update the HEAD pointer in the current branch though, since
> it's only updating the remote, so I think you need an extra step to update
> the local branch.

e.g. with a different repo:

% git rev-parse HEAD
cacaae7
% git fetch
   cacaae7..75a0efb  master     -> origin/master
% git rev-parse HEAD
cacaae7

But you probably want to checkout 75a0efb now.
(Assignee)

Comment 4

4 years ago
Ah, you're correct that's a change in behaviour. Previously it would do a fresh clone every time so you'd get latest master if you didn't pass --commit. In practice I always use --commit, and if not I prefer taking the current state of the repo since I can mess with it manually. This also matches how the other media update scripts work, so I think it's a reasonable change.

I'll update the commit message to document the behaviour change.
https://hg.mozilla.org/mozilla-central/rev/9a60bf065716
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.