Closed Bug 1155029 Opened 5 years ago Closed 5 years ago

[mozrunner] get device log from both main buffer and radio buffer

Categories

(Testing :: Mozbase, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox40 fixed)

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file)

Get device log from both main buffer and radio buffer, e.g. `adb logcat -v time -b main -b radio', which can help us to understand emulator's radio behaviour. This is really helpful when debugging some intermittent failure which is caused by emulator environment, like bug 1155022.
Attached patch Patch, v1Splinter Review
Attachment #8593164 - Attachment is patch: true
Comment on attachment 8593164 [details] [diff] [review]
Patch, v1

Review of attachment 8593164 [details] [diff] [review]:
-----------------------------------------------------------------

Hi :ahal, would you mind reviewing this? Thank you.
Attachment #8593164 - Flags: review?(ahalberstadt)
Assignee: nobody → echen
Comment on attachment 8593164 [details] [diff] [review]
Patch, v1

Review of attachment 8593164 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, lgtm! Will this dump both the radio and main buffers into the same log file?
Attachment #8593164 - Flags: review?(ahalberstadt) → review+
(In reply to Andrew Halberstadt [:ahal] from comment #3)
> Comment on attachment 8593164 [details] [diff] [review]
> Patch, v1
> 
> Review of attachment 8593164 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks, lgtm! Will this dump both the radio and main buffers into the same
> log file?

Yes, will be in the same log file.

If you are interesting about what will the log look like, here is the try run with dumping both the radio and main buffer for your reference, https://treeherder.mozilla.org/#/jobs?repo=try&revision=234d28040682&exclusion_profile=false (The tag of radio log is `RIL` or `AT`).

Thank you.
https://hg.mozilla.org/mozilla-central/rev/86970b32c0c8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.