1155029 - [mozrunner] get device log from both main buffer and radio buffer

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Edgar Chen [:edgar]]

Get device log from both main buffer and radio buffer, e.g. `adb logcat -v time -b main -b radio', which can help us to understand emulator's radio behaviour. This is really helpful when debugging some intermittent failure which is caused by emulator environment, like bug 1155022.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8593164 [details] [diff] [review]
Patch, v1

Review of attachment 8593164 [details] [diff] [review]:
-----------------------------------------------------------------

Hi :ahal, would you mind reviewing this? Thank you.

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8593164 [details] [diff] [review]
Patch, v1

Review of attachment 8593164 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, lgtm! Will this dump both the radio and main buffers into the same log file?

Comment 4

[Edgar Chen [:edgar]]

(In reply to Andrew Halberstadt [:ahal] from comment #3)
> Comment on attachment 8593164 [details] [diff] [review]
> Patch, v1
> 
> Review of attachment 8593164 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks, lgtm! Will this dump both the radio and main buffers into the same
> log file?

Yes, will be in the same log file.

If you are interesting about what will the log look like, here is the try run with dumping both the radio and main buffer for your reference, https://treeherder.mozilla.org/#/jobs?repo=try&revision=234d28040682&exclusion_profile=false (The tag of radio log is `RIL` or `AT`).

Thank you.

Comment 5

[Edgar Chen [:edgar]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4036406e40b&exclusion_profile=false

Comment 6

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/86970b32c0c8

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/86970b32c0c8