1155195 - Please disable screen sharing for 38

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Sylvestre Ledru [:Sylvestre]]

As agreed, please provide a patch and an uplift request (beta only) to disable screen sharing in Desktop for 38.0.
We will accept it, next Friday, after beta 5 go to build.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Mike, could you take care of that? Thanks

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: disable Loop screensharing for Fx38

Approval Request Comment
[Feature/regressing bug #]: Loop Screensharing feature
[User impact if declined]: This patch disables screensharing for Fx38 by flipping the appropriate pref.
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: n/a
[String/UUID change made/needed]: n/a

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8593884 [details] [diff] [review]
Patch v1: disable Loop screensharing for Fx38

Review of attachment 8593884 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I think you wanted beta for the 38 release ;-)

Comment 4

[Mike de Boer [:mikedeboer]]

Ah yes, I meant beta ;) Thanks!

Sylvestre, I assume the sherriffs will take care of landing this at the appropriate moment?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Yes, they will! No need to do anything!

Comment 6

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6a5c3aa5b912

Comment 7

[Bogdan Maris, Desktop QA]

Verified across platforms (Windows 8.1 x64, Mac OS X 10.9.5, Ubuntu 14.04 x64) that Screensharing for Hello is disabled ('loop.screenshare.enabled' has value 'false' by default) on Firefox 38 beta 6.