Closed Bug 1155195 Opened 5 years ago Closed 5 years ago

Please disable screen sharing for 38

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox38+ verified, firefox39 wontfix, firefox40 wontfix)

VERIFIED FIXED
mozilla38
Tracking Status
firefox38 + verified
firefox39 --- wontfix
firefox40 --- wontfix

People

(Reporter: Sylvestre, Assigned: mikedeboer)

References

Details

(Whiteboard: [screensharing])

Attachments

(1 file)

As agreed, please provide a patch and an uplift request (beta only) to disable screen sharing in Desktop for 38.0.
We will accept it, next Friday, after beta 5 go to build.
Mike, could you take care of that? Thanks
Flags: needinfo?(mdeboer)
Depends on: 1146938
Rank: 1
Priority: -- → P1
Whiteboard: [screensharing]
Flags: firefox-backlog+
Approval Request Comment
[Feature/regressing bug #]: Loop Screensharing feature
[User impact if declined]: This patch disables screensharing for Fx38 by flipping the appropriate pref.
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: n/a
[String/UUID change made/needed]: n/a
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Flags: needinfo?(mdeboer)
Attachment #8593884 - Flags: review?(standard8)
Attachment #8593884 - Flags: approval-mozilla-aurora?
OS: Linux → All
Hardware: x86_64 → All
Comment on attachment 8593884 [details] [diff] [review]
Patch v1: disable Loop screensharing for Fx38

Review of attachment 8593884 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I think you wanted beta for the 38 release ;-)
Attachment #8593884 - Flags: review?(standard8)
Attachment #8593884 - Flags: review+
Attachment #8593884 - Flags: approval-mozilla-beta?
Attachment #8593884 - Flags: approval-mozilla-aurora?
Attachment #8593884 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Ah yes, I meant beta ;) Thanks!

Sylvestre, I assume the sherriffs will take care of landing this at the appropriate moment?
Flags: needinfo?(sledru)
Yes, they will! No need to do anything!
Flags: needinfo?(sledru)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Flags: qe-verify+
Verified across platforms (Windows 8.1 x64, Mac OS X 10.9.5, Ubuntu 14.04 x64) that Screensharing for Hello is disabled ('loop.screenshare.enabled' has value 'false' by default) on Firefox 38 beta 6.
Status: RESOLVED → VERIFIED
Blocks: 1157196
You need to log in before you can comment on or make changes to this bug.