Closed
Bug 1155359
Opened 7 years ago
Closed 7 years ago
nsTextBoxFrame doesn't layout RTL unless RTL characters are present
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla40
People
(Reporter: gw280, Assigned: gw280)
References
Details
Attachments
(2 files)
819 bytes,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
1.63 KB,
patch
|
gw280
:
review+
|
Details | Diff | Splinter Review |
If you style a XUL label with "direction: rtl;", unless it contains RTL characters, it prematurely optimises away the bidi processing. We should change it to also do bidi processing if the CSS style is set to RTL.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8593561 -
Flags: review?(roc)
Comment on attachment 8593561 [details] [diff] [review] rtl-nstextboxframe.patch Review of attachment 8593561 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/xul/nsTextBoxFrame.cpp @@ +636,5 @@ > aRenderingContext); > if (titleWidth <= aWidth) { > mCroppedTitle = mTitle; > + if (HasRTLChars(mTitle) || > + StyleContext()->StyleVisibility()->mDirection == NS_STYLE_DIRECTION_RTL) { StyleContext()-> is redundant, remove it
Attachment #8593561 -
Flags: review?(roc) → review+
Assignee | ||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dc252c85f6c
Comment 4•7 years ago
|
||
Attachment #8594006 -
Flags: review?(gwright)
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8594006 [details] [diff] [review] Add a reftest Review of attachment 8594006 [details] [diff] [review]: ----------------------------------------------------------------- Oops, sorry I forgot to do this!
Attachment #8594006 -
Flags: review?(gwright) → review+
![]() |
||
Updated•7 years ago
|
tracking-e10s:
--- → m6+
Comment 7•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6dc252c85f6c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment 9•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a2ed859e2a5d https://hg.mozilla.org/mozilla-central/rev/10d7f9fa3d90
You need to log in
before you can comment on or make changes to this bug.
Description
•