1155359 - nsTextBoxFrame doesn't layout RTL unless RTL characters are present

Status: RESOLVED FIXED

Description

[George Wright (:gw280) (needinfo me!)]

If you style a XUL label with "direction: rtl;", unless it contains RTL characters, it prematurely optimises away the bidi processing.

We should change it to also do bidi processing if the CSS style is set to RTL.

Comment 1

[George Wright (:gw280) (needinfo me!)]

Created attachment 8593561 [details] [diff] [review]
rtl-nstextboxframe.patch

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8593561 [details] [diff] [review]
rtl-nstextboxframe.patch

Review of attachment 8593561 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/xul/nsTextBoxFrame.cpp
@@ +636,5 @@
>                                                aRenderingContext);
>      if (titleWidth <= aWidth) {
>          mCroppedTitle = mTitle;
> +        if (HasRTLChars(mTitle) ||
> +            StyleContext()->StyleVisibility()->mDirection == NS_STYLE_DIRECTION_RTL) {

StyleContext()-> is redundant, remove it

Comment 3

[George Wright (:gw280) (needinfo me!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6dc252c85f6c

Comment 4

[:Ehsan Akhgari]

Created attachment 8594006 [details] [diff] [review]
Add a reftest

Comment 5

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8594006 [details] [diff] [review]
Add a reftest

Review of attachment 8594006 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, sorry I forgot to do this!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2ed859e2a5d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6dc252c85f6c

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/10d7f9fa3d90

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a2ed859e2a5d
https://hg.mozilla.org/mozilla-central/rev/10d7f9fa3d90