1155589 - Add the first marionette test

Status: RESOLVED FIXED

(support.mozilla.org :: BuddyUp, defect)

Description

[Johan Lorenzo [:jlorenzo]]

This would be great to have an integration test running with MarionetteJS.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: PR

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8593852 [details] [review]
PR

Hi guys,

I think the integration test is ready, with a good usage of the Page Object pattern. 

Rik, does the test run on your computer? Do you think the JS-style is consistent with what you have in BuddyUp? Do you see any big JS issue? 

John, as we discussed yesterday, I saw you have some interesting parts with the clock app. I tried to comply with what you got. Do you see anything that we need to talk about?

Side note: Don't mind the 15 ridiculously small commits, I'll squash everything once you guys r+.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8593852 [details] [review]
PR

Last Friday, during the community event, :Bebe noticed that this PR has bit rot. I investigated why, and I think this is related to bug 1164684, where client was globally accessible.

Would you mind reviewing this patch, so we could avoid another rotting?

Comment 4

[Anthony Ricaud (:rik)]

Can you run "jshint app" on your patch? I see 52 errors with the current patch.

Comment 5

[Anthony Ricaud (:rik)]

Comment on attachment 8593852 [details] [review]
PR

This is working on my machine! Thanks for all the work.

Let's do another round of review for the various comments but they are minor, not logic related.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8593852 [details] [review]
PR

JSHint is not yelling anymore, and I fixed/commented the issues you raised.

Comment 7

[Anthony Ricaud (:rik)]

Comment on attachment 8593852 [details] [review]
PR

Super !

Comment 8

[Anthony Ricaud (:rik)]

https://github.com/mozilla/buddyup/commit/029f6014cd3eadb0043e175d8769522008c7d1f8