1155597 - Quick share icons are too big in quick share context menu (Gingerbread)

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: IMG_20150417_100408.jpg

Steps to reproduce:
1. Set up sync
2. Go to news.google.com
3. Long tap on a link 
4. Choose "Share Link" -> "Send to other devices" from context menu
5. Long tap once again on the link

Expected results: 
- All icon items from quickshare context menu should be the same size

Actual results: 
- Share plane in quick share context menu is bigger than the three-dots-connected share icon

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

omg, fragmentation!

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot of the issue (2 items)

Looks like this is for all icons, not just the share plane. This could be a regression from restyling the MenuItemActionBar at some point or changing the share icon asset, but I'm not sure.

Anthony, would you rather decrease the size of the application icons or increase the size of the share icon?

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We dynamically set the context menu padding:
  https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/menu/MenuItemActionView.java?rev=a9738e5f636a#176

And only have a values/ and values-v21/ configuration:
  https://mxr.mozilla.org/mozilla-central/search?string=context_menu_item_&find=mobile%2Fandroid&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

I'm going to say that's our problem.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

But then again, that's only horizontal padding so I don't think it will work.

In any case, this is not super important so I'm going to unassign myself.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We're killing GB.