Closed Bug 1155651 Opened 5 years ago Closed 5 years ago
Actor should return all animation below a given node
39 bytes, text/x-review-board-request
The animation panel is more useful if when a node is selected, all animations on that node + on nodes in its subtree are displayed. This way, when <html> or <body> are selected, it's possible to see all animations. And at the same time, it's still possible to select a leaf node and see only the animations on that node if needed. This will require changes to the AnimationsActor.getAnimationPlayersForNode method. There shouldn't be any backwards compatibility problems here because the front-end has never made the assumption that all displayed players were for one node only, so it should just work if the actor method is changed.
/r/7197 - Bug 1155651 - Return all players below a node in getAnimationPlayersForNode Pull down this commit: hg pull -r 15e6b144309823031f6b345dd9bf76ccd40179f5 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8593965 - Flags: review?(mratcliffe)
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #2) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=fecab36448a5 Of course, I didn't run the browser/devtools/animationinspector tests locally, and I should have, 3 of them are failing. That's because with this patch, selecting the <body> node in the inspector now shows all animations. It used to show no animations at all, and that's what these 3 tests were assuming. I'll fix these tests and upload a new patch for review.
Comment on attachment 8593965 [details] MozReview Request: bz://1155651/pbrosset /r/7197 - Bug 1155651 - Return all players below a node in getAnimationPlayersForNode Pull down this commit: hg pull -r f0aaf586bbd527f55dc1f47461f480b0a7ec2e43 https://reviewboard-hg.mozilla.org/gecko/
And a new try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=99e8206f9346
There are 2 remaining intermittents in the browser/devtools/animationinspector tests. Working on a fix now. This will be a test-only fix anyway, the main part of the patch won't change.
Comment on attachment 8593965 [details] MozReview Request: bz://1155651/pbrosset https://reviewboard.mozilla.org/r/7195/#review6197 Ship It!
Attachment #8593965 - Flags: review?(mratcliffe) → review+
Thanks Mike. One last try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a46154c80b38 All green except for seemingly unrelated failures on linux e10s. I don't see how my patch could make this test fail. So I'll push to try: https://hg.mozilla.org/integration/fx-team/rev/c419bd2f3976
Component: Developer Tools: Inspector → Developer Tools: Animation Inspector
You need to log in before you can comment on or make changes to this bug.