Closed Bug 1155652 Opened 5 years ago Closed 5 years ago

Fix a bad assertion in ActorsParent.cpp

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(2 files)

Found by coverity (cid 1294707), we have a wrong assertion. Moreover, it creates a different behavior between release and debug builds.
Attachment #8593942 - Flags: review?(Jan.Varga)
Assignee: nobody → sledru
Comment on attachment 8593942 [details] [diff] [review]
side-effect-assert.diff

Review of attachment 8593942 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8593942 - Flags: review?(Jan.Varga) → review+
Can you also fix it in ~WaitForTransactionsHelper() ?
Attached patch 1155652.diffSplinter Review
Sure, here it is. Carrying review.

The tree is closed. The push will wait.
Attachment #8593969 - Flags: review+
Keywords: checkin-needed
The other CID is 1274356
https://hg.mozilla.org/mozilla-central/rev/810b4e284ef4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.