Closed
Bug 1155652
Opened 10 years ago
Closed 10 years ago
Fix a bad assertion in ActorsParent.cpp
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(2 files)
|
615 bytes,
patch
|
janv
:
review+
|
Details | Diff | Splinter Review |
|
1.09 KB,
patch
|
Sylvestre
:
review+
|
Details | Diff | Splinter Review |
Found by coverity (cid 1294707), we have a wrong assertion. Moreover, it creates a different behavior between release and debug builds.
Attachment #8593942 -
Flags: review?(Jan.Varga)
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → sledru
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8593942 [details] [diff] [review]
side-effect-assert.diff
Review of attachment 8593942 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8593942 -
Flags: review?(Jan.Varga) → review+
|
|
||
Comment 2•10 years ago
|
||
Can you also fix it in ~WaitForTransactionsHelper() ?
|
|
Assignee | |
Comment 3•10 years ago
|
||
Sure, here it is. Carrying review.
The tree is closed. The push will wait.
Attachment #8593969 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•10 years ago
|
||
The other CID is 1274356
|
||
Comment 5•10 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
|
|
Assignee | |
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•