1155681 - Jetpack extension buttons are missing their icon

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Tom S. (please needinfo tschuster)]

I am using a currently nightly and all of my Jetpack buttons in the toolbar have no icon and the button is shrunk down like this http://i.imgur.com/HV4AWRV.png .

Relevant code snippet:
<toolbarbutton xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="action-button--mozilla-tree-statusjsantellcom-tree-status-button" class="toolbarbutton-1 chromeclass-toolbar-additional badged-button" type="undefined" label="mozilla-inbound status: CLOSED, Bug 1155630 Infra/tooltool issue" tooltiptext="mozilla-inbound status: CLOSED, Bug 1155630 Infra/tooltool issue" image="resource://mozilla-tree-status-at-jsantell-dot-com/mozilla-tree-status/data/tree_closed.svg" constrain-size="true" cui-areatype="toolbar" badge=""/>

Mike suggested removing the "badged-button" class, which made the icon appear again.

Comment 1

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

If you have a few minutes, is there any chance you could take a look at this, Dao?

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

this makes the linux styling match the windows styling

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/bd128b529a76

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bd128b529a76

Comment 5

[Cornel Ionce [:noni]]

Tom, could you please confirm that the latest Nightly is no longer affected by this?

I could not configure the Add-on SDK (Jetpack) on my Ubuntu 14.04 64-bit, due to several console errors.

Comment 6

[Tom S. (please needinfo tschuster)]

It's fixed for me.

Comment 7

[Cornel Ionce [:noni]]

Thanks!
Based on this, I'm marking as verified.