Closed Bug 1155681 Opened 9 years ago Closed 9 years ago

Jetpack extension buttons are missing their icon

Categories

(Firefox :: Theme, defect)

x86
Linux
defect
Not set
normal
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 40
Iteration:
40.3 - 11 May
Tracking Status
firefox40 --- verified

People

(Reporter: evilpie, Assigned: dao)

References

(Depends on 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

I am using a currently nightly and all of my Jetpack buttons in the toolbar have no icon and the button is shrunk down like this http://i.imgur.com/HV4AWRV.png .

Relevant code snippet:
<toolbarbutton xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="action-button--mozilla-tree-statusjsantellcom-tree-status-button" class="toolbarbutton-1 chromeclass-toolbar-additional badged-button" type="undefined" label="mozilla-inbound status: CLOSED, Bug 1155630 Infra/tooltool issue" tooltiptext="mozilla-inbound status: CLOSED, Bug 1155630 Infra/tooltool issue" image="resource://mozilla-tree-status-at-jsantell-dot-com/mozilla-tree-status/data/tree_closed.svg" constrain-size="true" cui-areatype="toolbar" badge=""/>

Mike suggested removing the "badged-button" class, which made the icon appear again.
Flags: firefox-backlog+
If you have a few minutes, is there any chance you could take a look at this, Dao?
Flags: needinfo?(dao)
Attached patch patchSplinter Review
this makes the linux styling match the windows styling
Assignee: nobody → dao
Status: NEW → ASSIGNED
Flags: needinfo?(dao)
Attachment #8598736 - Flags: review?(gijskruitbosch+bugs)
Iteration: --- → 40.3 - 11 May
Points: --- → 2
Flags: qe-verify+
Attachment #8598736 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/bd128b529a76
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
QA Contact: cornel.ionce
Tom, could you please confirm that the latest Nightly is no longer affected by this?

I could not configure the Add-on SDK (Jetpack) on my Ubuntu 14.04 64-bit, due to several console errors.
Flags: needinfo?(evilpies)
It's fixed for me.
Flags: needinfo?(evilpies)
Thanks!
Based on this, I'm marking as verified.
Status: RESOLVED → VERIFIED
Depends on: 1220386
You need to log in before you can comment on or make changes to this bug.