11557 - nsIFileSpec.idl should forward declare nsFileSpec

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect, P5)

Description

[Patrick C. Beard]

Currently, it explicitly includes "nsFileSpec.h" which brings in a lot of extra
#includes for everybody, namely nsString.h, and friends. This causes lots of
source files to implicitly get nsString, nsCRT, etc.

In my tree, I've experimented with this and have had to touch the following list
of files to get them to correctly, explicitly #include nsString.h and nsCRT.h:

mozilla/mailnews/mime/emitters/src/nsEmitterUtils.cpp
mozilla/mailnews/imap/src/nsImapStringBundle.cpp
mozilla/mailnews/addrbook/src/nsCardDataSource.cpp
mozilla/xpfe/components/history/src/nsGlobalHistory.cpp
mozilla/layout/base/src/nsPresContext.cpp
mozilla/xpcom/components/xcDll.cpp
mozilla/netwerk/protocol/http/src/nsHTTPHandler.cpp
mozilla/mailnews/mime/emitters/src/nsMimeXmlEmitter.cpp
mozilla/mailnews/mime/emitters/src/nsMimeHtmlEmitter.cpp
mozilla/mailnews/compose/src/nsMsgComposeStringBundle.cpp
mozilla/netwerk/base/src/nsLoadGroup.cpp
mozilla/modules/libimg/src/if.cpp
mozilla/netwerk/protocol/about/src/nsAboutProtocolHandler.cpp

Comment 1

[Doug Turner (:dougt)]

Do you want to check these changes in?

Comment 2

[Patrick C. Beard]

I have been propagating them forward but keep getting conflicts, so I filed this
bug to notify you of the problem. And there hasn't been a good time to check them
in. They're easy to find, just make the change to nsIFileSpec.idl, and things
will start to break, usually because they need either nsString.h or nsCRT.h.

Comment 3

[Doug Turner (:dougt)]

risky change before m9 tree closure.  Setting target milestone to m10.

Comment 4

[Doug Turner (:dougt)]

moving to m11.

Comment 5

[Doug Turner (:dougt)]

moving to m11.

Comment 6

[Doug Turner (:dougt)]

moving after beta.

Comment 7

[Doug Turner (:dougt)]

will be fixed by 22047

Comment 8

[Doug Turner (:dougt)]

users should not be using nsFileSpec any longer.

Comment 9

[Doug Turner (:dougt)]

nsfilespec is dead.