1155708 - Make Marionette.Element#size and #location use element rect

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

getElementLocation and getElementSize in Marionette are deprecated in favour of the less bandwidth-intensive getElementRect.  Fortunately, it's backwards-compatible and we should be able to call that function for Marionette.Element#size and Marionette.Element#location and extract the properties we are interested in.

Comment 1

[Andreas Tolfsen ❲:ato❳]

https://github.com/mozilla-b2g/marionette-js-client/pull/138

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: GitHub PR

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8597260 [details] [review]
GitHub PR

Added a few comments on GH. Mostly I'm not seeing the conversion from the getElementRect responses to the previous size and location responses?

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/marionette-js-client/commit/5519020f8d3966192775f2c885fb84a6c9ad71c3 LGTM

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia-node-modules] gaye:marionette-js-client-1.7.5 > mozilla-b2g:master

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

Landed in gaia-node-modules master https://github.com/mozilla-b2g/gaia-node-modules/commit/db2cb234952a58ce70409ffaa1cd1c839b21d5d8

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] gaye:bug-1155708-marionette-client-1.7.5 > mozilla-b2g:master

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

Landed on gaia master https://github.com/mozilla-b2g/gaia/commit/d0ac1f67e1b62e4d6dd5028fb09f2439170df54e