Closed Bug 1155718 Opened 10 years ago Closed 10 years ago

Merge Bluetooth v1/v2 files for all simple cases

Tracking

(firefox40 fixed)

Status:

RESOLVED FIXED

Milestone:

2.2 S11 (1may)

Tracking Flags:

Tracking

Status

firefox40

---

fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

(Depends on 1 open bug)

Details

Attachments

(7 files)

[01] Bug 1155718: Share BluetoothHfpMangerBase.h between Bluetooth v1 and v2 10 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 1.62 KB, patch	ben.tian : review+	Details \| Diff \| Splinter Review
[02] Bug 1155718: Share BluetoothHidManager.{cpp,h} between Bluetooth v1 and v2 10 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 11.50 KB, patch	ben.tian : review+	Details \| Diff \| Splinter Review
[03] Bug 1155718: Share BluetoothProfileManagerBase.h between Bluetooth v1 and v2 10 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 5.05 KB, patch	ben.tian : review+	Details \| Diff \| Splinter Review
[04] Bug 1155718: Share BlueoothRilListener.{cpp,h} between Bluetooth v1 and v2 10 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 18.06 KB, patch	ben.tian : review+	Details \| Diff \| Splinter Review
[05] Bug 1155718: Share BluetoothSocketObserver.h between Bluetooth v1 and v2 10 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 2.21 KB, patch	ben.tian : review+	Details \| Diff \| Splinter Review
[06] Bug 1155718: Share ObexBase.{cpp,h} between Bluetooth v1 and v2 10 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 12.95 KB, patch	ben.tian : review+	Details \| Diff \| Splinter Review
[07] Bug 1155718: Update CLOBBER 10 years ago Thomas Zimmermann [:tzimmermann] [:tdz] 964 bytes, patch	ben.tian : review+	Details \| Diff \| Splinter Review

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Description

•

10 years ago

There are a number of files in which are basically the same in Bluetooth v1 and v2. I think we can speed up the merging process by reviewing and landing them in a single bug report.

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 1

•

10 years ago

Attached patch [01] Bug 1155718: Share BluetoothHfpMangerBase.h between Bluetooth v1 and v2 — Details — Splinter Review

Attachment #8594060 - Flags: review?(btian)

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 2

•

10 years ago

Attached patch [02] Bug 1155718: Share BluetoothHidManager.{cpp,h} between Bluetooth v1 and v2 — Details — Splinter Review

Attachment #8594061 - Flags: review?(btian)

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 3

•

10 years ago

Attached patch [03] Bug 1155718: Share BluetoothProfileManagerBase.h between Bluetooth v1 and v2 — Details — Splinter Review

Attachment #8594062 - Flags: review?(btian)

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 4

•

10 years ago

Attached patch [04] Bug 1155718: Share BlueoothRilListener.{cpp,h} between Bluetooth v1 and v2 — Details — Splinter Review

Attachment #8594063 - Flags: review?(btian)

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 5

•

10 years ago

Attached patch [05] Bug 1155718: Share BluetoothSocketObserver.h between Bluetooth v1 and v2 — Details — Splinter Review

Attachment #8594064 - Flags: review?(btian)

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 6

•

10 years ago

Attached patch [06] Bug 1155718: Share ObexBase.{cpp,h} between Bluetooth v1 and v2 — Details — Splinter Review

Attachment #8594065 - Flags: review?(btian)

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 7

•

10 years ago

Attached patch [07] Bug 1155718: Update CLOBBER — Details — Splinter Review

Attachment #8594066 - Flags: review?(btian)

Ben Tian (inactive)

Comment 8

•

10 years ago

Comment on attachment 8594060 [details] [diff] [review] [01] Bug 1155718: Share BluetoothHfpMangerBase.h between Bluetooth v1 and v2 Review of attachment 8594060 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Attachment #8594060 - Flags: review?(btian) → review+

Ben Tian (inactive)

Comment 9

•

10 years ago

Comment on attachment 8594061 [details] [diff] [review] [02] Bug 1155718: Share BluetoothHidManager.{cpp,h} between Bluetooth v1 and v2 Review of attachment 8594061 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Attachment #8594061 - Flags: review?(btian) → review+

Ben Tian (inactive)

Comment 10

•

10 years ago

Comment on attachment 8594063 [details] [diff] [review] [04] Bug 1155718: Share BlueoothRilListener.{cpp,h} between Bluetooth v1 and v2 Review of attachment 8594063 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Attachment #8594063 - Flags: review?(btian) → review+

Ben Tian (inactive)

Comment 11

•

10 years ago

Comment on attachment 8594064 [details] [diff] [review] [05] Bug 1155718: Share BluetoothSocketObserver.h between Bluetooth v1 and v2 Review of attachment 8594064 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Attachment #8594064 - Flags: review?(btian) → review+

Ben Tian (inactive)

Comment 12

•

10 years ago

Comment on attachment 8594065 [details] [diff] [review] [06] Bug 1155718: Share ObexBase.{cpp,h} between Bluetooth v1 and v2 Review of attachment 8594065 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Attachment #8594065 - Flags: review?(btian) → review+

Ben Tian (inactive)

Comment 13

•

10 years ago

Comment on attachment 8594066 [details] [diff] [review] [07] Bug 1155718: Update CLOBBER Review of attachment 8594066 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Attachment #8594066 - Flags: review?(btian) → review+

Ben Tian (inactive)

Comment 14

•

10 years ago

Comment on attachment 8594062 [details] [diff] [review] [03] Bug 1155718: Share BluetoothProfileManagerBase.h between Bluetooth v1 and v2 Review of attachment 8594062 [details] [diff] [review]: ----------------------------------------------------------------- LGTM

Attachment #8594062 - Flags: review?(btian) → review+

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 15

•

10 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=efe46553a5d1

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Updated

•

10 years ago

Blocks: 1156229

Pulsebot

Comment 16

•

10 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/17961ff7b9a8 https://hg.mozilla.org/integration/b2g-inbound/rev/c77c3f0057a3 https://hg.mozilla.org/integration/b2g-inbound/rev/93dfb0bc5389 https://hg.mozilla.org/integration/b2g-inbound/rev/3d43df500149 https://hg.mozilla.org/integration/b2g-inbound/rev/90993be4d17d https://hg.mozilla.org/integration/b2g-inbound/rev/bf459581c994 https://hg.mozilla.org/integration/b2g-inbound/rev/54ff3f209c78

Thomas Zimmermann [:tzimmermann] [:tdz]

Assignee

Comment 17

•

10 years ago

Thanks Ben! https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=54ff3f209c78

Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)

Comment 18

•

10 years ago

https://hg.mozilla.org/mozilla-central/rev/17961ff7b9a8 https://hg.mozilla.org/mozilla-central/rev/c77c3f0057a3 https://hg.mozilla.org/mozilla-central/rev/93dfb0bc5389 https://hg.mozilla.org/mozilla-central/rev/3d43df500149 https://hg.mozilla.org/mozilla-central/rev/90993be4d17d https://hg.mozilla.org/mozilla-central/rev/bf459581c994 https://hg.mozilla.org/mozilla-central/rev/54ff3f209c78

Status: ASSIGNED → RESOLVED

Closed: 10 years ago

status-firefox40: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 2.2 S11 (1may)

You need to log in before you can comment on or make changes to this bug.