Closed Bug 1155718 Opened 5 years ago Closed 5 years ago

Merge Bluetooth v1/v2 files for all simple cases

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox40 fixed)

RESOLVED FIXED
2.2 S11 (1may)
Tracking Status
firefox40 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

(Depends on 1 open bug)

Details

Attachments

(7 files)

There are a number of files in which are basically the same in Bluetooth v1 and v2. I think we can speed up the merging process by reviewing and landing them in a single bug report.
Comment on attachment 8594060 [details] [diff] [review]
[01] Bug 1155718: Share BluetoothHfpMangerBase.h between Bluetooth v1 and v2

Review of attachment 8594060 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8594060 - Flags: review?(btian) → review+
Comment on attachment 8594061 [details] [diff] [review]
[02] Bug 1155718: Share BluetoothHidManager.{cpp,h} between Bluetooth v1 and v2

Review of attachment 8594061 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8594061 - Flags: review?(btian) → review+
Comment on attachment 8594063 [details] [diff] [review]
[04] Bug 1155718: Share BlueoothRilListener.{cpp,h} between Bluetooth v1 and v2

Review of attachment 8594063 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8594063 - Flags: review?(btian) → review+
Comment on attachment 8594064 [details] [diff] [review]
[05] Bug 1155718: Share BluetoothSocketObserver.h between Bluetooth v1 and v2

Review of attachment 8594064 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8594064 - Flags: review?(btian) → review+
Comment on attachment 8594065 [details] [diff] [review]
[06] Bug 1155718: Share ObexBase.{cpp,h} between Bluetooth v1 and v2

Review of attachment 8594065 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8594065 - Flags: review?(btian) → review+
Comment on attachment 8594066 [details] [diff] [review]
[07] Bug 1155718: Update CLOBBER

Review of attachment 8594066 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8594066 - Flags: review?(btian) → review+
Comment on attachment 8594062 [details] [diff] [review]
[03] Bug 1155718: Share BluetoothProfileManagerBase.h between Bluetooth v1 and v2

Review of attachment 8594062 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8594062 - Flags: review?(btian) → review+
You need to log in before you can comment on or make changes to this bug.