1155748 - [System] "TypeError: slot.simCard.iccInfo is null" when booting my Flame

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

I see this error when booting my Flame with 2 SIMs inside:

04-17 18:36:19.900 19293 19293 W GeckoConsole: [JavaScript Error: "TypeError: slot.simCard.iccInfo is null" {file: "app://system.gaiamobile.org/js/operator_variant_manager.js" line: 60}]

I don't know if there is any user-facing issue but at least this prevents subsequent code from running, which could be bad.

Comment 1

[Gregor Wagner [:gwagner]]

Arthur, any ideas?

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Although I'm not able to reproduce it but it seems a racing. The iccinfo may not ready upon the starting up. I'll provide a patch later.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] crh0716:1155748 > mozilla-b2g:master

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8595719 [details] [review]
[gaia] crh0716:1155748 > mozilla-b2g:master

Alive, in this patch I added an additional handler on simslot-iccinfochange so that we can run the operator variant handler at the correct time. A check on iccInfo was also added. The logic of the checks and operator variant handler creation was moved to a separate function to avoid code duplication. Would you mind take a look at it when you get a chance? Thanks.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Julien, could you try whether the patch fixes the issue? Thanks.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8595719 [details] [review]
[gaia] crh0716:1155748 > mozilla-b2g:master

Thanks!

Comment 7

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

Actually it's difficult to say, I don't see this everytime I boot the Flame (actually quite rarely). So I can't check for sure this fixes the issue (but I think it does).

Also I'm not sure how I could check that everything still works as expected, but I applied the patch and used the phone simply and it seems to work fine. I'll assume alive knows better about it :)

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Indeed, it is a racing and might be difficult to reproduce. Let's commit the code first and reopen the bug if it occurs again.

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/83fdebe5dc8a5ae1202273c368cdf7148d5cd852

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8595719 [details] [review]
[gaia] crh0716:1155748 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: The possibility is low but once happened the operator variant settings may not be applied correctly.
[Testing completed]: Unit test added. Testing on the device ok but note that the the original reproduce rate is pretty low.  
[Risk to taking this patch] (and alternatives if risky): Low. It fixes a racing by listening to events from gecko.
[String changes made]: None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/95742e457223ded53869c2d8188e29d229d9a9a9