If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Raptor] Make ro.product.model to config key comparison case-insensitive

RESOLVED FIXED

Status

Firefox OS
Gaia::PerformanceTest
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Eli, Assigned: Eli)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

3 years ago
It is possible for device's to have different casing for their product model, e.g. `adb shell getprop ro.product.model` can return "Flame" or "flame". We need to update the config.json key comparison case-insensitive so we can avoid errors for "missing" devices.
(Assignee)

Comment 1

3 years ago
Created attachment 8595591 [details] [review]
Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/14

To test this out, it's easiest to just modify the code before running the test. It seems we can't do `setprop ro.product.model Flame`, so at line 138 in the index.js file, add `model = 'Flame';`.
Attachment #8595591 - Flags: review?(rwood)

Comment 2

3 years ago
Comment on attachment 8595591 [details] [review]
Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/14

LGTM and works great, tested with model 'flame' and 'Flame', and also an invalid model.
Attachment #8595591 - Flags: review?(rwood) → review+

Comment 3

3 years ago
Created attachment 8598135 [details] [review]
[gaia-node-modules] eliperelman:bug-1155814 > mozilla-b2g:master
(Assignee)

Comment 4

3 years ago
Comment on attachment 8598135 [details] [review]
[gaia-node-modules] eliperelman:bug-1155814 > mozilla-b2g:master

Carrying over r+ for package bump.
Attachment #8598135 - Flags: review+

Comment 5

3 years ago
Created attachment 8598137 [details] [review]
[gaia] eliperelman:bug-1155814 > mozilla-b2g:master
(Assignee)

Comment 6

3 years ago
Comment on attachment 8598137 [details] [review]
[gaia] eliperelman:bug-1155814 > mozilla-b2g:master

Carrying over r+ for package bump.
Attachment #8598137 - Flags: review+
(Assignee)

Comment 7

3 years ago
In master: https://github.com/mozilla-b2g/gaia/commit/a9f6218d6b79e93072677515a5fc15f226233f5c
Released in gaia-raptor@1.4.1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

3 years ago
In mozdevice@2.1.3
You need to log in before you can comment on or make changes to this bug.