1155814 - [Raptor] Make ro.product.model to config key comparison case-insensitive

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[:Eli Perelman]

It is possible for device's to have different casing for their product model, e.g. `adb shell getprop ro.product.model` can return "Flame" or "flame". We need to update the config.json key comparison case-insensitive so we can avoid errors for "missing" devices.

Comment 1

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/14

To test this out, it's easiest to just modify the code before running the test. It seems we can't do `setprop ro.product.model Flame`, so at line 138 in the index.js file, add `model = 'Flame';`.

Comment 2

[Robert Wood [:rwood]]

Comment on attachment 8595591 [details] [review]
Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/14

LGTM and works great, tested with model 'flame' and 'Flame', and also an invalid model.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia-node-modules] eliperelman:bug-1155814 > mozilla-b2g:master

Comment 4

[:Eli Perelman]

Comment on attachment 8598135 [details] [review]
[gaia-node-modules] eliperelman:bug-1155814 > mozilla-b2g:master

Carrying over r+ for package bump.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] eliperelman:bug-1155814 > mozilla-b2g:master

Comment 6

[:Eli Perelman]

Comment on attachment 8598137 [details] [review]
[gaia] eliperelman:bug-1155814 > mozilla-b2g:master

Carrying over r+ for package bump.

Comment 7

[:Eli Perelman]

In master: https://github.com/mozilla-b2g/gaia/commit/a9f6218d6b79e93072677515a5fc15f226233f5c
Released in gaia-raptor@1.4.1

Comment 8

[:Eli Perelman]

In mozdevice@2.1.3