Closed
Bug 1155823
Opened 9 years ago
Closed 9 years ago
Properly shutdown the CompositorVsyncDispatcher
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mchang, Assigned: mchang)
References
Details
Attachments
(1 file)
1.59 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
Previously, we shut down the compositor vsync dispatcher at the nsBaseWidget's destructor which is when we shut down the compositor. We changed when we destroy the compositor in bug 1125848 from the destructor to nsBaseWidget::Shutdown. We need to update calling CompositorVsyncDispatcher::Shutdown during nsBaseWidget::Shutdown.
Assignee | ||
Comment 1•9 years ago
|
||
Updated docs on how we shutdown: https://github.com/changm/SilkDocs/blob/master/silk.md
Attachment #8594121 -
Flags: review?(bugmail.mozilla)
Comment 2•9 years ago
|
||
Marking this as blocking bug 1125848 per comment 0. Also marking it dependent on bug 1134385 which has the patch for silk shutdown documentation.
Comment 3•9 years ago
|
||
Comment on attachment 8594121 [details] [diff] [review] Properly shutdown compositor vsync dispatcher Clearing review until the comments in bug 1134385 are dealt with and we (or I, at least) have a clearer understanding of the shutdown procedure.
Attachment #8594121 -
Flags: review?(bugmail.mozilla)
Updated•9 years ago
|
Attachment #8594121 -
Flags: review+
https://hg.mozilla.org/mozilla-central/rev/7e9c4abf391b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•