1155823 - Properly shutdown the CompositorVsyncDispatcher

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mason Chang [Inactive] [:mchang]]

Previously, we shut down the compositor vsync dispatcher at the nsBaseWidget's destructor which is when we shut down the compositor. We changed when we destroy the compositor in bug 1125848 from the destructor to nsBaseWidget::Shutdown. We need to update calling CompositorVsyncDispatcher::Shutdown during nsBaseWidget::Shutdown.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Properly shutdown compositor vsync dispatcher

Updated docs on how we shutdown: https://github.com/changm/SilkDocs/blob/master/silk.md

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Marking this as blocking bug 1125848 per comment 0. Also marking it dependent on bug 1134385 which has the patch for silk shutdown documentation.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8594121 [details] [diff] [review]
Properly shutdown compositor vsync dispatcher

Clearing review until the comments in bug 1134385 are dealt with and we (or I, at least) have a clearer understanding of the shutdown procedure.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e9c4abf391b

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7e9c4abf391b