1155846 - Intentionally unreachable code in Prefetcher.jsm.

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Tooru Fujisawa [:arai]]

I'm going to add warning for unreachable code after return statement in bug 1151931,
and it hits following code.

https://dxr.mozilla.org/mozilla-central/source/toolkit/components/addoncompat/Prefetcher.jsm#104
> function log(...args)
> {
>   return;
> 
>   for (let arg of args) {
>     dump(arg);
>     dump(" ");
>   }
>   dump("\n");
> }

https://dxr.mozilla.org/mozilla-central/source/toolkit/components/addoncompat/Prefetcher.jsm#115
> function logPrefetch(kind, value1, component, value2)
> {
>   return;
>   log("prefetching", kind, objAddr(value1) + "." + component, "=", objAddr(value2));
> }

can we comment out those function body, instead of placing `return`?
(it might be better to also comment out rest parameter, to improve performance)

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Comment out intentionally unreachable code and unused parameters in Prefetcher.jsm.

Just commented out body and parameters.
if there is better solution, let me know :)

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8594148 [details] [diff] [review]
Comment out intentionally unreachable code and unused parameters in Prefetcher.jsm.

Review of attachment 8594148 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this is okay, although I think the warning is a bad idea.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0a97dd5ee96

Comment 4

[Tooru Fujisawa [:arai]]

do you think the warning should be behind javascript.options.strict option, or shouldn't be added at all?

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f0a97dd5ee96