1155877 - I am tired of objects that let typos return `undefined` instead of telling me that I have made a typo

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: MozReview Request: bz://1155877/Yoric

/r/7237 - Bug 1155877 - ObjectUtils.strict;r=mossop

Pull down this commit:

hg pull -r 067cfee07a2490b6933a22417753b58b0bda97aa https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[David Teller [:Yoric] - still alive but not very active]

I find myself implementing this over and over again for debugging, so I believe we can as well put it in our library.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8594237 [details]
MozReview Request: bz://1155877/Yoric

https://reviewboard.mozilla.org/r/7235/#review6001

::: toolkit/modules/ObjectUtils.jsm
(Diff revision 1)
> +  if (!AppConstants.DEBUG) {

Why would we only do this in debug builds? If only valid properties of an object are meant to be accessed in debug mode I don't know why it wouldn't be the case in non-debug. This creates a gotcha that can only confuse.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Fine by me. I just wanted to avoid the cost of a Proxy.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8594237 [details]
MozReview Request: bz://1155877/Yoric

/r/7237 - Bug 1155877 - ObjectUtils.strict;r=mossop

Pull down this commit:

hg pull -r 97bab5e2bee6415eeed6505e5f61927e0bca5171 https://reviewboard-hg.mozilla.org/gecko/

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8594237 [details]
MozReview Request: bz://1155877/Yoric

https://reviewboard.mozilla.org/r/7235/#review6005

Ship It!

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9df48264b26b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cee13569d8d4

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cee13569d8d4

Comment 11

[David Teller [:Yoric] - still alive but not very active]

Attachment: MozReview Request: Bug 1155877 - ObjectUtils.strict;r=mossop