1155939 - [EME] Test for deleting GMP plugin directory on removal

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: 1155939-test-gmp-removal.patch

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: 1155939-gmp-removal-fixes.patch

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Gtest green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e5bfac1f06a

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8594278 [details] [diff] [review]
1155939-test-gmp-removal.patch

Review of attachment 8594278 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03ce639c4f13
https://hg.mozilla.org/integration/mozilla-inbound/rev/f06080c6097f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out for frequent Linux GMP gtest deadlocks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5f607d68c66

https://treeherder.mozilla.org/logviewer.html#?job_id=9062300&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=9062301&repo=mozilla-inbound

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d432365ffdba
https://hg.mozilla.org/integration/mozilla-inbound/rev/6930eaf79724

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Note: in bug 1159300 I landed a fix to this test to make it only use an EME-capable video decoder, so that we always are trying to get a specific GMP, since bug 1159300 added another GMPs.

So if this bug gets backed out again, or uplifted, please take the following changeset too:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7da86419656

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d432365ffdba
https://hg.mozilla.org/mozilla-central/rev/6930eaf79724