1155940 - make browser_354894_perwindowpb.js wait for load and SSTabRestored after doing undoCloseTab

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Timothy Nikkel (:tnikkel)]

The patch for bug 1063369 (which I would like to land) turns browser_354894_perwindowpb.js orange. After some experimenting on try server this appears to be because we don't wait for undeCloseTab to finish loading the window and it's in some half restored state, which confuses the new window creation that happens next. I don't claim to understand exactly what is going on, but waiting for undeCloseTab to finish seems to be the correct thing to do.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8594280 [details] [diff] [review]
patch

Review of attachment 8594280 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/test/browser_354894_perwindowpb.js
@@ +368,5 @@
>          browserWindowsCount([0, 1], "browser windows while running testOpenCloseRestoreFromPopup");
>  
>          newWin = undoCloseWindow(0);
> +        newWin.addEventListener("load", function() {
> +          newWin.removeEventListener("load", arguments.callee, false);

Please remove arguments.callee here while you're at it, thanks :)

@@ +373,3 @@
>  
> +          newWin.gBrowser.tabContainer.addEventListener("SSTabRestored", function () {
> +            newWin.gBrowser.tabContainer.removeEventListener("SSTabRestored", arguments.callee, false);

Please don't use arguments.callee but name the function instead.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c4bb45a2f1d

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c614c698220

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5c4bb45a2f1d
https://hg.mozilla.org/mozilla-central/rev/1c614c698220