Add push information to about:serviceworkers

RESOLVED FIXED in Firefox 40

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

unspecified
mozilla40
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8594438 [details] [diff] [review]
add_push_to_about_serviceworkers

thoughts?
Attachment #8594438 - Flags: review?(amarchesini)
Comment on attachment 8594438 [details] [diff] [review]
add_push_to_about_serviceworkers

Review of attachment 8594438 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutServiceWorkers.js
@@ +12,5 @@
> +XPCOMUtils.defineLazyServiceGetter(
> +  this,
> +  "PushNotificationService",
> +  "@mozilla.org/push/NotificationService;1",
> +  "nsIPushNotificationService"

does it exist? I don't find it in m-c.

Can you point me to where this is implemented?
Attachment #8594438 - Flags: review?(amarchesini)
I would like to see if we can show more than just a JSON.stringify but I didn't find where nsIPushNotificationService is implemented.
Flags: needinfo?(dougt)
(Assignee)

Comment 4

4 years ago
nsIPush* hasn't landed yet. See bug 1150683.
Depends on: 1150683
Flags: needinfo?(dougt)
(Assignee)

Comment 5

4 years ago
Created attachment 8594702 [details]
Screenshot 2015-04-20 12.43.05.png
(Assignee)

Updated

4 years ago
Attachment #8594438 - Flags: review?(amarchesini)
Comment on attachment 8594438 [details] [diff] [review]
add_push_to_about_serviceworkers

Review of attachment 8594438 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, but file a bug to make a better UI.
Attachment #8594438 - Flags: review?(amarchesini) → review+
(Assignee)

Updated

4 years ago
Blocks: 1156702
(Assignee)

Updated

4 years ago
No longer blocks: 1156702
https://hg.mozilla.org/mozilla-central/rev/a5eee04c796e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.