Closed Bug 1156052 Opened 8 years ago Closed 8 years ago

Add push information to about:serviceworkers

Categories

(Core :: DOM: Push Notifications, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(2 files)

No description provided.
thoughts?
Attachment #8594438 - Flags: review?(amarchesini)
Comment on attachment 8594438 [details] [diff] [review]
add_push_to_about_serviceworkers

Review of attachment 8594438 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutServiceWorkers.js
@@ +12,5 @@
> +XPCOMUtils.defineLazyServiceGetter(
> +  this,
> +  "PushNotificationService",
> +  "@mozilla.org/push/NotificationService;1",
> +  "nsIPushNotificationService"

does it exist? I don't find it in m-c.

Can you point me to where this is implemented?
Attachment #8594438 - Flags: review?(amarchesini)
I would like to see if we can show more than just a JSON.stringify but I didn't find where nsIPushNotificationService is implemented.
Flags: needinfo?(dougt)
nsIPush* hasn't landed yet. See bug 1150683.
Depends on: 1150683
Flags: needinfo?(dougt)
Attachment #8594438 - Flags: review?(amarchesini)
Comment on attachment 8594438 [details] [diff] [review]
add_push_to_about_serviceworkers

Review of attachment 8594438 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, but file a bug to make a better UI.
Attachment #8594438 - Flags: review?(amarchesini) → review+
Blocks: 1156702
No longer blocks: 1156702
https://hg.mozilla.org/mozilla-central/rev/a5eee04c796e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.