1156183 - [Stingray][TvDeck] Move TVManager related API to ChannelManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Sung Chiu[:sungchiu]]

It would be better to move (tuner, source, channel) related functions or properties to ChannelManager and leave TVDeck for UI manipulations.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] sean2449:Bug_1156183-move-channel > mozilla-b2g:master

Comment 2

[Sung Chiu[:sungchiu]]

Comment on attachment 8597873 [details] [review]
[gaia] sean2449:Bug_1156183-move-channel > mozilla-b2g:master

1. Move TVManager related API to ChannelManager.
2. Rewrite test case for TVDeck.
3. Add flag isScanning in channelManager since setCurrentSource and setCurrentChannel can not be called when a tuner is scanning. setHash should not be called either.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8597873 [details] [review]
[gaia] sean2449:Bug_1156183-move-channel > mozilla-b2g:master

Looks good but it has some spaces to improve.

Comment 4

[Sung Chiu[:sungchiu]]

Comment on attachment 8597873 [details] [review]
[gaia] sean2449:Bug_1156183-move-channel > mozilla-b2g:master

John, thanks for the suggestions in PR, I have made following changes:
1. Change (playingTunerId, playingSourceType, playingChannelNumber) to playingState with (tunerId, sourceType, channelNumber) properties.
2. Refocus to panel element when buttongroup is hidden.
3. Change playingTuner, playingSource and playingChannel properties to getTuner, getSource and getChannel functions.

Comment 5

[Sung Chiu[:sungchiu]]

4. Move UI related pin or unpin card functions from channel manager to tv-deck.
5. Move CardManager related functions to pin_card.js

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8597873 [details] [review]
[gaia] sean2449:Bug_1156183-move-channel > mozilla-b2g:master

Looks good to me. Please file another bug to add unit tests for your newly created modules.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/a47c511cc970466cb4c939a1d4a051d3bc6dfb26